From 521d349e2f232dae558e8777a59d8f70daaece63 Mon Sep 17 00:00:00 2001 From: Sam Smith Date: Fri, 1 Sep 2023 15:56:12 -0400 Subject: [PATCH] Package updates (#552) * UPdated packages * updated action --- .github/workflows/workflow.yml | 2 +- .../RepoGovernance.BlazorPOC.csproj | 2 +- .../RepoGovernance.Core.csproj | 8 +-- .../SummaryItemsControllerTests.cs | 58 +++++++++---------- 4 files changed, 35 insertions(+), 35 deletions(-) diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml index 908f9662..aa19ac29 100644 --- a/.github/workflows/workflow.yml +++ b/.github/workflows/workflow.yml @@ -102,7 +102,7 @@ jobs: if: github.ref == 'refs/heads/main' steps: - name: Run Sonarcloud test - uses: samsmithnz/SamsDotNetSonarCloudAction@1.2.0 + uses: samsmithnz/SamsDotNetSonarCloudAction@2.0.0 with: projects: 'src/RepoGovernance.Core/RepoGovernance.Core.csproj,src/RepoGovernance.Tests/RepoGovernance.Tests.csproj,src/RepoGovernance.Service/RepoGovernance.Service.csproj,src/RepoGovernance.Web/RepoGovernance.Web.csproj,src/RepoGovernance.Function/RepoGovernance.Function.csproj' dotnet-version: '7.0.x' diff --git a/src/RepoGovernance.BlazorPOC/RepoGovernance.BlazorPOC.csproj b/src/RepoGovernance.BlazorPOC/RepoGovernance.BlazorPOC.csproj index a3427d39..2fdde3ae 100644 --- a/src/RepoGovernance.BlazorPOC/RepoGovernance.BlazorPOC.csproj +++ b/src/RepoGovernance.BlazorPOC/RepoGovernance.BlazorPOC.csproj @@ -10,7 +10,7 @@ - + diff --git a/src/RepoGovernance.Core/RepoGovernance.Core.csproj b/src/RepoGovernance.Core/RepoGovernance.Core.csproj index 1b30fc4d..079afda2 100644 --- a/src/RepoGovernance.Core/RepoGovernance.Core.csproj +++ b/src/RepoGovernance.Core/RepoGovernance.Core.csproj @@ -9,11 +9,11 @@ - - + + - - + + diff --git a/src/RepoGovernance.Tests/SummaryItemsControllerTests.cs b/src/RepoGovernance.Tests/SummaryItemsControllerTests.cs index 0bd350ed..9fbfab55 100644 --- a/src/RepoGovernance.Tests/SummaryItemsControllerTests.cs +++ b/src/RepoGovernance.Tests/SummaryItemsControllerTests.cs @@ -32,10 +32,10 @@ public async Task UpdateRepoGovernanceSummaryItemTest() //Act - runs a repo in about 4s int itemsUpdated = await SummaryItemsDA.UpdateSummaryItem( - GitHubId, - GitHubSecret, - AzureStorageConnectionString, - DevOpsServiceURL, + GitHubId, + GitHubSecret, + AzureStorageConnectionString, + DevOpsServiceURL, user, owner, repo, AzureTenantId, AzureClientId, @@ -67,10 +67,10 @@ public async Task UpdateDevOpsMetricsSummaryItemTest() //Act - runs a repo in about 4s int itemsUpdated = await SummaryItemsDA.UpdateSummaryItem( - GitHubId, - GitHubSecret, - AzureStorageConnectionString, - DevOpsServiceURL, + GitHubId, + GitHubSecret, + AzureStorageConnectionString, + DevOpsServiceURL, user, owner, repo, AzureTenantId, AzureClientId, @@ -100,10 +100,10 @@ public async Task UpdateSamsFeatureFlagsSummaryItemTest() //Act - runs a repo in about 4s int itemsUpdated = await SummaryItemsDA.UpdateSummaryItem( - GitHubId, - GitHubSecret, - AzureStorageConnectionString, - DevOpsServiceURL, + GitHubId, + GitHubSecret, + AzureStorageConnectionString, + DevOpsServiceURL, user, owner, repo, AzureTenantId, AzureClientId, @@ -132,10 +132,10 @@ public async Task UpdateSamSmithNZdotComSummaryItemTest() //Act - runs a repo in about 4s int itemsUpdated = await SummaryItemsDA.UpdateSummaryItem( - GitHubId, - GitHubSecret, - AzureStorageConnectionString, - DevOpsServiceURL, + GitHubId, + GitHubSecret, + AzureStorageConnectionString, + DevOpsServiceURL, user, owner, repo, AzureTenantId, AzureClientId, @@ -164,10 +164,10 @@ public async Task UpdateAzurePipelinesToGitHubActionsConverterWebSummaryItemTest //Act - runs a repo in about 4s int itemsUpdated = await SummaryItemsDA.UpdateSummaryItem( - GitHubId, - GitHubSecret, - AzureStorageConnectionString, - DevOpsServiceURL, + GitHubId, + GitHubSecret, + AzureStorageConnectionString, + DevOpsServiceURL, user, owner, repo, AzureTenantId, AzureClientId, @@ -269,18 +269,18 @@ public async Task GetSummaryItemsTest() { Assert.AreEqual("CustomQueue", item2.Repo); Assert.IsNotNull(item2.RepoSettings); - Assert.AreEqual(1, item2.RepoSettingsRecommendations.Count); - Assert.AreEqual("Consider disabling 'Allow rebase merge' in repo settings, as rebasing can be confusing", item2.RepoSettingsRecommendations[0]); + Assert.AreEqual(0, item2.RepoSettingsRecommendations.Count); + //Assert.AreEqual("Consider disabling 'Allow rebase merge' in repo settings, as rebasing can be confusing", item2.RepoSettingsRecommendations[0]); Assert.AreEqual(1, item2.Actions.Count); Assert.AreEqual(0, item2.ActionRecommendations.Count); - Assert.AreEqual(0, item2.Dependabot.Count); - Assert.AreEqual(null, item2.DependabotFile); - Assert.AreEqual(null, item2.DependabotRoot); - Assert.AreEqual(1, item2.DependabotRecommendations.Count); - Assert.AreEqual("Consider adding a Dependabot file to automatically update dependencies", item2.DependabotRecommendations[0]); + Assert.AreEqual(1, item2.Dependabot.Count); + Assert.IsNotNull(item2.DependabotFile); + Assert.IsNotNull(item2.DependabotRoot); + Assert.AreEqual(0, item2.DependabotRecommendations.Count); + //Assert.AreEqual("Consider adding a Dependabot file to automatically update dependencies", item2.DependabotRecommendations[0]); Assert.IsNotNull(item2.BranchPolicies); - Assert.AreEqual(1, item2.BranchPoliciesRecommendations.Count); - Assert.AreEqual("Consider enabling 'Enforce Admins', to ensure that all users of the repo must follow branch policy rules", item2.BranchPoliciesRecommendations[0]); + Assert.AreEqual(0, item2.BranchPoliciesRecommendations.Count); + //Assert.AreEqual("Consider enabling 'Enforce Admins', to ensure that all users of the repo must follow branch policy rules", item2.BranchPoliciesRecommendations[0]); Assert.AreEqual(1, item2.GitVersion.Count); Assert.AreEqual(0, item2.GitVersionRecommendations.Count); //Assert.AreEqual("Consider adding Git Versioning to this repo", item2.GitVersionRecommendations[0]);