Add linux browser detach support #2

Merged
merged 3 commits into from Jul 29, 2011

Conversation

Projects
None yet
2 participants
@jdkcn
Contributor

jdkcn commented Jul 28, 2011

Hi,samsnow

I just add linux browser detach support.

Include dolphin (KDE), nautilus(Gnome), thunar(xfce), pcmanfm(lxde), rox.

@samsonw

This comment has been minimized.

Show comment
Hide comment
@samsonw

samsonw Jul 28, 2011

Owner

Thanks rory, do you mean browser detect?

Owner

samsonw commented Jul 28, 2011

Thanks rory, do you mean browser detect?

@jdkcn

This comment has been minimized.

Show comment
Hide comment
@jdkcn

jdkcn Jul 29, 2011

Contributor

yes. In linux threre so many DE and filemanager .We can support more not just Gnome's nautilus
BTW, I add the commons-lang, and commons-io dependency. If u think it's bad about this. I'll remove them,How do you think?

Contributor

jdkcn commented Jul 29, 2011

yes. In linux threre so many DE and filemanager .We can support more not just Gnome's nautilus
BTW, I add the commons-lang, and commons-io dependency. If u think it's bad about this. I'll remove them,How do you think?

@jdkcn

This comment has been minimized.

Show comment
Hide comment
@jdkcn

jdkcn Jul 29, 2011

Contributor

ok, I remove the two jars.
Please review it and release a new version?

Thanks.

Contributor

jdkcn commented Jul 29, 2011

ok, I remove the two jars.
Please review it and release a new version?

Thanks.

@samsonw

This comment has been minimized.

Show comment
Hide comment
@samsonw

samsonw Jul 29, 2011

Owner

I was actually thinking about adding a preference for this. So if multiple file managers are installed, user doesn't have to follow the order we specified here in the IF-ELSE clause.

Thanks for the patch, this should be a good place to go on.

Owner

samsonw commented Jul 29, 2011

I was actually thinking about adding a preference for this. So if multiple file managers are installed, user doesn't have to follow the order we specified here in the IF-ELSE clause.

Thanks for the patch, this should be a good place to go on.

samsonw added a commit that referenced this pull request Jul 29, 2011

Merge pull request #2 from jdkcn/master
Add linux browser detect support, multiple file managers are supported now (dolphin, nautilus, thunar, rox etc)

@samsonw samsonw merged commit e9838ba into samsonw:master Jul 29, 2011

@jdkcn

This comment has been minimized.

Show comment
Hide comment
@jdkcn

jdkcn Jul 30, 2011

Contributor

I agree.I actual try too find the preference about this plugin when I try on my box failed.But not found so I found the source and just add this detach for most Linux users.

BTW: thanks give us this nice plugin.

Contributor

jdkcn commented Jul 30, 2011

I agree.I actual try too find the preference about this plugin when I try on my box failed.But not found so I found the source and just add this detach for most Linux users.

BTW: thanks give us this nice plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment