New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Pathogen problem and Added a functionality #5

Merged
merged 2 commits into from Mar 6, 2012

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Mar 3, 2012

In order to fix the Pathogen problem, I simply renamed the ftplugin dir to plugin.

Also for the ftplugin/task.vim script file, i modified the original Toggle_task_status():
The idea was that nothing will happen if the function is invoked while the line is not part of a task.
With the current modification, if the function is called on a non-task line, this line will be appended a '-' in beginning of line.

The last modification I made was to be able to remove a line from the 'task' list.

I have also added shortcuts for them accordingly.

The README file is changed accordingly to reflect the changes.

I hope my explanations where clear and that you will merge them to the main repo. In any case, I am always available for feedback

@samsonw

View changes

Show outdated Hide outdated README.mkd
@samsonw

View changes

Show outdated Hide outdated README.mkd
@samsonw

This comment has been minimized.

Show comment
Hide comment
@samsonw

samsonw Mar 5, 2012

Owner

Hi, thanks for the patch, add a "-" for non task line is a good idea, I would really like to merge your pull request if you can revert some of the shortcut key modifications as commented inline above.

Owner

samsonw commented Mar 5, 2012

Hi, thanks for the patch, add a "-" for non task line is a good idea, I would really like to merge your pull request if you can revert some of the shortcut key modifications as commented inline above.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Mar 6, 2012

Ok reverted my changes to the Keybindings.

I also removed the function I added though did a slight modification to Toggle_task_status(). I realized that I could just add another small line that would toggle from '-' to the tick and then empty it (as if the task was removed).
I don't really know how to explain it, but probably by trying it, it would make sense :D

Cheers

ghost commented Mar 6, 2012

Ok reverted my changes to the Keybindings.

I also removed the function I added though did a slight modification to Toggle_task_status(). I realized that I could just add another small line that would toggle from '-' to the tick and then empty it (as if the task was removed).
I don't really know how to explain it, but probably by trying it, it would make sense :D

Cheers

@samsonw

This comment has been minimized.

Show comment
Hide comment
@samsonw

samsonw Mar 6, 2012

Owner

thx for the patch, yeah it makes sense to me :)

Owner

samsonw commented Mar 6, 2012

thx for the patch, yeah it makes sense to me :)

samsonw added a commit that referenced this pull request Mar 6, 2012

Merge pull request #5 from tUrG0n/master
Fixed Pathogen problem and Added a functionality

@samsonw samsonw merged commit 7e93a0c into samsonw:master Mar 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment