Fixed Pathogen problem and Added a functionality #5

Merged
merged 2 commits into from Mar 6, 2012

Projects

None yet

2 participants

@piotryordanov

In order to fix the Pathogen problem, I simply renamed the ftplugin dir to plugin.

Also for the ftplugin/task.vim script file, i modified the original Toggle_task_status():
The idea was that nothing will happen if the function is invoked while the line is not part of a task.
With the current modification, if the function is called on a non-task line, this line will be appended a '-' in beginning of line.

The last modification I made was to be able to remove a line from the 'task' list.

I have also added shortcuts for them accordingly.

The README file is changed accordingly to reflect the changes.

I hope my explanations where clear and that you will merge them to the main repo. In any case, I am always available for feedback

Piotr Yordanov Submiting changes 7010ece
@samsonw samsonw commented on an outdated diff Mar 5, 2012
README.mkd
## Shortcut Key, Key Binding & Customization
-By default, I mapped Ctrl+Command+Enter for toggling task status, you can simply remap to what’s the most comfortable for you:
+By default, I mapped Alt-z for toggling task status, you can simply remap to what’s the most comfortable for you:
@samsonw
samsonw Mar 5, 2012 Owner

I'm not comfortable to change the shortcut key right now, it will be great if you can revert the shortcut key modification here.

@samsonw samsonw commented on an outdated diff Mar 5, 2012
README.mkd
- inoremap <silent> <buffer> <C-D-CR> <ESC>:call Toggle_task_status()<CR>i
- noremap <silent> <buffer> <C-D-CR> :call Toggle_task_status()<CR>
+ inoremap <silent> <buffer> <M-z> <ESC>:call Toggle_task_status()<CR>i
+ noremap <silent> <buffer> <M-z> :call Toggle_task_status()<CR>
+ inoremap <silent> <buffer> <M-Z> :call Toggle_task_status_remove()<CR>i
+ noremap <silent> <buffer> <M-Z> :call Toggle_task_status_remove()<CR>
@samsonw
samsonw Mar 5, 2012 Owner

same as above.

@samsonw
Owner
samsonw commented Mar 5, 2012

Hi, thanks for the patch, add a "-" for non task line is a good idea, I would really like to merge your pull request if you can revert some of the shortcut key modifications as commented inline above.

@piotryordanov

Ok reverted my changes to the Keybindings.

I also removed the function I added though did a slight modification to Toggle_task_status(). I realized that I could just add another small line that would toggle from '-' to the tick and then empty it (as if the task was removed).
I don't really know how to explain it, but probably by trying it, it would make sense :D

Cheers

@samsonw
Owner
samsonw commented Mar 6, 2012

thx for the patch, yeah it makes sense to me :)

@samsonw samsonw merged commit 7e93a0c into samsonw:master Mar 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment