Permalink
Browse files

Merge pull request #19 from spharris/fix-thing-equivalence

Fixed thing == <not a Thing> bug
  • Loading branch information...
2 parents 71d1150 + 38770cf commit e2f9b8853c3893ac96819ca38c94d0471c70a89b Sam Symons committed Jan 31, 2014
Showing with 941 additions and 204 deletions.
  1. +1 −0 lib/redditkit/thing.rb
  2. +51 −4 spec/cassettes/RedditKit_Client_Flair/_flair_list/returns_the_list_of_flair.yml
  3. +70 −23 spec/cassettes/RedditKit_Client_Moderation/_ban/requests_the_correct_resource.yml
  4. +52 −5 ...assettes/RedditKit_Client_Moderation/_contributors_to_subreddit/requests_the_correct_resource.yml
  5. +150 −109 ...ssettes/RedditKit_Client_Moderation/_moderation_log/returns_RedditKit_ModeratorAction_objects.yml
  6. +53 −6 .../cassettes/RedditKit_Client_Moderation/_moderators_of_subreddit/requests_the_correct_resource.yml
  7. +61 −14 spec/cassettes/RedditKit_Client_Moderation/_unban/requests_the_correct_resource.yml
  8. +49 −7 spec/cassettes/RedditKit_Client_Multireddits/_multireddit/without_a_path/returns_a_multireddit.yml
  9. +102 −11 ...nt_Multireddits/_multireddit_description/with_a_multireddit/returns_a_multireddit_description.yml
  10. +54 −5 ...ultireddit_description/with_a_username_and_multireddit_name/returns_a_multireddit_description.yml
  11. +58 −4 spec/cassettes/RedditKit_Client_Wiki/_add_wiki_editor/requests_the_correct_resource.yml
  12. +58 −4 spec/cassettes/RedditKit_Client_Wiki/_edit_wiki_page/requests_the_correct_resource.yml
  13. +58 −4 spec/cassettes/RedditKit_Client_Wiki/_hide_wiki_revision/requests_the_correct_resource.yml
  14. +58 −4 spec/cassettes/RedditKit_Client_Wiki/_remove_wiki_editor/requests_the_correct_resource.yml
  15. +58 −4 spec/cassettes/RedditKit_Client_Wiki/_revert_to_revision/requests_the_correct_resource.yml
  16. +8 −0 spec/redditkit/thing_spec.rb
View
@@ -9,6 +9,7 @@ class Thing < RedditKit::Base
attr_reader :kind
def ==(other)
+ return false unless other.is_a?(Thing)
full_name == other.full_name
end

Some generated files are not rendered by default. Learn more.

Oops, something went wrong.

Some generated files are not rendered by default. Learn more.

Oops, something went wrong.

Some generated files are not rendered by default. Learn more.

Oops, something went wrong.
Oops, something went wrong.

0 comments on commit e2f9b88

Please sign in to comment.