Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix Client.register doc and functionality #3

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

euank commented Nov 17, 2013

Register api documentation was inaccurate and required captcha items were in the options hash. Email was also missing.

The version bump I'm not sure you actually want. Feel free to disregard it or ask me to redo the pull request without it.

euank added some commits Nov 17, 2013

Clean up register api
Move required parameters out of options, make docs match
what it actually takes
Bump major version
By semver you bump this for any incompatible change,
which the change to the register api is.
Owner

samsymons commented Nov 17, 2013

This is good, thanks. I'm gonna hold off on merging it for now as I plan to have OAuth implemented very soon, so I'll keep that for the version 2 bump.

Contributor

BukhariH commented Jan 8, 2014

@euank could you send another pull request with just commit b7ec6d8 as it's useful however is still backwards compatible.

Contributor

euank commented Jan 8, 2014

@BukhariH: added as #15

Contributor

BukhariH commented Jan 8, 2014

@euank Thanks Euan!

jtoy commented Jan 21, 2014

is oauth coming in?

Owner

samsymons commented Jan 22, 2014

@jtoy Yep, sorry for taking so long on that, I keep getting distracted by everything else. I'll be taking a look at that on Thursday.

jtoy commented Feb 1, 2014

Just checking, is there a timeline for oauth?

Owner

samsymons commented Feb 2, 2014

Quite soon – I'm working on it as we speak. Sorry for taking so long with it, I've recently started a new job so life has been pretty hectic.

jtoy commented Feb 7, 2014

hi :)

Contributor

BukhariH commented Feb 8, 2014

@jtoy There is no easy way to implement oauth without messing it up massively. And, you don't have to look far to see some example's of poor oauth implementation (which aren't due to bad developers).

An example being GitHub:
http://homakov.blogspot.co.uk/2014/02/how-i-hacked-github-again.html

Implementing it the right way is about atleast 2-3 weeks work.

Secondly, we have to decide how do we want to implement it. Do we want to Faraday and Oauth using middleware or do we want a separate library like oauth2 working in conjunction with faraday?

Apart from that reddit's documentation for Oauth is terrible. There is literally only this page:
https://github.com/reddit/reddit/wiki/OAuth2

Contributor

euank commented Nov 17, 2016

I don't actively use this library anymore and I'd need to rebase.

If this change is still needed, anyone else is welcome to pick up my changes and carry them, but I'll just close this since I have no plans to act further here.

@euank euank closed this Nov 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment