/htsjdk

New issue

more VariantContext attribute getters #371

Closed
ldgauthier opened this Issue Nov 6, 2015 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ldgauthier @yfarjoun @d-cameron
@ldgauthier
Contributor

ldgauthier commented Nov 6, 2015

@yfarjoun thinks it "would be nice to have utility functions getAttributeAs<*>List for * in String,Integer,Long,Double...."
@yfarjoun
Contributor

yfarjoun commented Nov 6, 2015

and @ldgauthier "agrees"
@d-cameron
Contributor

d-cameron commented Feb 19, 2016

Are there any plans to optionally enforce header typing on VariantContext attributes? It'd be nice if we could assume that the type in the header actually round-trips and matches the type defined in the header for that field. Currently we have to do something along the lines of this to get usable attributes.

@magicDGS magicDGS added a commit to magicDGS/htsjdk that referenced this issue Sep 17, 2016

@magicDGS magicDGS fixes #371 8f890d7

magicDGS referenced this issue Sep 17, 2016

Merged

More getters for VariantContext #712

2 of 5 tasks complete

@magicDGS magicDGS added a commit to magicDGS/htsjdk that referenced this issue Sep 21, 2016

@magicDGS @magicDGS magicDGS + magicDGS fixes #371 b66919a

@magicDGS magicDGS added a commit to magicDGS/htsjdk that referenced this issue Nov 7, 2016

@magicDGS magicDGS fixes #371 60c64cd

yfarjoun closed this in #712 Nov 20, 2016

@yfarjoun yfarjoun added a commit that referenced this issue Nov 20, 2016

@magicDGS @yfarjoun magicDGS + yfarjoun More getters for VariantContext (#712) 
* fixes #371
* removed unused imports
* unit tests + solved bug in getAttributesAsList with primitive arrays
* added documentation about primitive arrays
 5ddddde
@yfarjoun
Contributor

yfarjoun commented Nov 20, 2016

@ldgauthier ask and ye shall recieve! thanks @magicDGS!!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment