New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restoring SRA support by updating the backing library #1142
Conversation
lbergelson
commented
Jun 6, 2018
- the underlying ngs-java library that supplies SRA support required updating in order to continue connecting to the SRA servers
- fixes SRA tests and restores support
- update ngs-java 1.2.4 -> 2.9.0
* the underlying ngs-java library that supplies SRA support required updating in order to continue connecting to the SRA servers * fixes SRA tests and restores support * update ngs-java 1.2.4 -> 2.9.0
@cmnbroad I was recently recontacted about SRA support. They published a new version of the library which seems to restore support for SRA ( at least according to the tests). |
Codecov Report
@@ Coverage Diff @@
## master #1142 +/- ##
==============================================
+ Coverage 66.052% 68.031% +1.98%
- Complexity 7685 7931 +246
==============================================
Files 538 538
Lines 32582 32607 +25
Branches 5529 5545 +16
==============================================
+ Hits 21521 22183 +662
+ Misses 8909 8195 -714
- Partials 2152 2229 +77
|
SRA tests now pass with this branch.
|
@lbergelson The change looks simple enough. Should we keep the SkipException tests and the exclusion for SRA when running tests locally ? Just checking to make sure there isn't anything else that needs to be be re-enabled. |
@cmnbroad I'm not sure what to do with the skip.. it's kind of a flakey test since it's over the internet, so the skip keeps it from randomly failing, but we also don't get alerted to it... Maybe we could move it to a separate test matrix entry? We should keep them as separate tests I think, some people don't like the auto-download of code that happens when you run them. |
Sounds like we should keep them as i for now at least. |