/htsjdk

made LazyInitializer a @FunctionalIterface to enable java8 sugar. #652

Merged
merged 1 commit into from Jun 28, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yfarjoun @tfenne @coveralls
@yfarjoun
Contributor

yfarjoun commented Jun 27, 2016

Description

The LazyInitilizer class can use java8 sugar but only if it's annotated correctly. This one-line PR makes that change.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
@yfarjoun yfarjoun made LazyInitializer a @FunctionalIterface to enable java8 sugar.

Some checks were not successful

1 failing and 2 successful checks
continuous-integration/travis-ci/push — The Travis CI build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 68.413%
Details
abc4c18
@yfarjoun
Contributor

yfarjoun commented Jun 27, 2016

@tfenne This is for the MV PR. can you take a quick look?
@tfenne
Owner

tfenne commented Jun 27, 2016

Looks good to me @yfarjoun
@yfarjoun
Contributor

yfarjoun commented Jun 27, 2016

SRA tests are failing....SRA!!!
@tfenne
Owner

tfenne commented Jun 27, 2016

image
@coveralls

coveralls commented Jun 28, 2016

Coverage Status

Coverage remained the same at 68.413% when pulling abc4c18 on yf_LazyInitializer_functional into 4cd5ef9 on master.

@yfarjoun yfarjoun merged commit 7084c88 into master Jun 28, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 68.413%
Details

yfarjoun deleted the yf_LazyInitializer_functional branch Jun 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment