/htsjdk

updating urls in tests to point to new locations #675

Merged
merged 1 commit into from Aug 3, 2016

Conversation

Reviewers
No reviews
Assignees

@lbergelson lbergelson

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@lbergelson @coveralls @droazen @nh13
@lbergelson
Contributor

lbergelson commented Aug 3, 2016 • edited

Description

Tests are breaking on master because of changed broad made to our webhosting

Checklist

  • Code compiles correctly
    - [ ] New tests covering changes and new functionality
  • All tests passing
    - [ ] Extended the README / documentation, if necessary
    - [ ] Is not backward compatible (breaks binary or source compatibility)

broad changed its website's urls from http://www.broadinstitute.org/~picard -> https://personal.broadinstitute.org/picard
there are redirects in place that work in most browsers, but our implementation of http can't follow the redirects

droazen was assigned by lbergelson Aug 3, 2016

@coveralls

coveralls commented Aug 3, 2016

Coverage Status

Changes Unknown when pulling cfbc611 on lb_move_urls_to_new_locations into * on master*.

@droazen droazen and 1 other commented on an outdated diff Aug 3, 2016

View full outdated diff
src/test/java/htsjdk/samtools/BAMRemoteFileTest.java
@@ -42,7 +42,7 @@
public class BAMRemoteFileTest {
private final File BAM_INDEX_FILE = new File("src/test/resources/htsjdk/samtools/BAMFileIndexTest/index_test.bam.bai");
private final File BAM_FILE = new File("src/test/resources/htsjdk/samtools/BAMFileIndexTest/index_test.bam");
- private final String BAM_URL_STRING = "http://www.broadinstitute.org/~picard/testdata/index_test.bam";
+ private final String BAM_URL_STRING = "https://personal.broadinstitute.org/picard/testdata/index_test.bam";
@droazen

droazen Aug 3, 2016

Contributor

Can https://personal.broadinstitute.org/picard/testdata/ be declared as a shared constant somewhere so that we don't have to do this again?

@lbergelson

lbergelson Aug 3, 2016

Contributor

sure
@droazen
Contributor

droazen commented Aug 3, 2016

One comment to address, then merge when ready 👍

@droazen droazen assigned lbergelson and unassigned droazen Aug 3, 2016

droazen referenced this pull request Aug 3, 2016

Closed

Request for a release of htsjdk #674

@lbergelson lbergelson updating urls in tests to point to new locations 
broad changed its website's urls from http://www.broadinstitute.org/~picard -> https://personal.broadinstitute.org/picard
there are redirects in place that work in most browsers, but our implementation of http can't follow the redirects

several tests need to have their urls updated

All checks have passed

3 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
coverage/coveralls — First build on master at 68.738%
Details
315b8c6
@coveralls

coveralls commented Aug 3, 2016

Coverage Status

Changes Unknown when pulling 315b8c6 on lb_move_urls_to_new_locations into * on master*.
@coveralls

coveralls commented Aug 3, 2016

Coverage Status

Changes Unknown when pulling 315b8c6 on lb_move_urls_to_new_locations into * on master*.

@lbergelson lbergelson merged commit 38713af into master Aug 3, 2016
3 checks passed

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on master at 68.738%
Details
@nh13
Contributor

nh13 commented Aug 3, 2016

@lbergelson remember to delete the branch

nh13 deleted the lb_move_urls_to_new_locations branch Aug 3, 2016

@jamesemery jamesemery added a commit to jamesemery/htsjdk that referenced this pull request Sep 1, 2016

@lbergelson @jamesemery lbergelson + jamesemery updating urls in tests to point to new locations (#675) 
Broad changed its website's urls from http://www.broadinstitute.org/~picard -> https://personal.broadinstitute.org/picard
there are redirects in place that work in most browsers, but our implementation of http can't follow the redirects

several tests needed to have their urls updated
 f84f3c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment