Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
deleting SAMFileReader and SAMTruncatedFileReader #699
Conversation
coveralls
commented
Sep 13, 2016
|
Can you check to make sure these classes are not used in either Picard or GATK3? |
lbergelson
was assigned
by droazen
Sep 13, 2016
|
@droazen Both Picard and GATK3 make use of them. How to proceed? |
|
@lbergelson Recommend that we open PRs (or at least, issues) against Picard and GATK3 to remove the usages before merging this. |
lbergelson
referenced
this pull request
in broadinstitute/picard
Sep 14, 2016
Closed
Replace SAMFileReader with SamReaderFactory #653
|
@droazen Opened issues and rebased this. Should we wait for them to be resolved or merge this before that happens? |
coveralls
commented
Sep 14, 2016
|
@lbergelson I'd say wait until the Picard one is merged, since it's simple, but don't wait for GATK3. |
magicDGS
referenced
this pull request
Sep 21, 2016
Merged
Clean some deprecated classes/methods usages in htsjdk #707
|
Uses were removed from both GATK and Picard so I'm going to merge this. |
lbergelson
merged commit 7ab2531
into
master
Oct 24, 2016
lbergelson
deleted the
lb_redelete_deprecated_reader branch
Oct 24, 2016
magicDGS
referenced
this pull request
Dec 5, 2016
Closed
SAMFileReader vanished in Version 2.7.0 #767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
lbergelson commentedSep 6, 2016
Description
The long deprecated
SAMFileReaderandSAMTruncatedFileReaderwere supposed to be deleted in #602. They seem to have been resurrected during the move to gradle.Fixes #695
renamed
SAMFileReaderTestto the more accurateSamReaderTestupdated usages of
SAMFileReaderin the documentation to beSamReaderChecklist