deleting SAMFileReader and SAMTruncatedFileReader #699

Merged
merged 1 commit into from Oct 24, 2016

Conversation

Projects
None yet
3 participants
Contributor

lbergelson commented Sep 6, 2016

Description

The long deprecated SAMFileReader and SAMTruncatedFileReader were supposed to be deleted in #602. They seem to have been resurrected during the move to gradle.

Fixes #695

renamed SAMFileReaderTest to the more accurate SamReaderTest
updated usages of SAMFileReader in the documentation to be SamReader

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

Coverage Status

Coverage increased (+0.5%) to 69.397% when pulling 92d8382 on lb_redelete_deprecated_reader into c3d5a88 on master.

Contributor

droazen commented Sep 13, 2016

Can you check to make sure these classes are not used in either Picard or GATK3?

lbergelson was assigned by droazen Sep 13, 2016

Contributor

lbergelson commented Sep 14, 2016

@droazen Both Picard and GATK3 make use of them. How to proceed?

Contributor

droazen commented Sep 14, 2016

@lbergelson Recommend that we open PRs (or at least, issues) against Picard and GATK3 to remove the usages before merging this.

lbergelson referenced this pull request in broadinstitute/picard Sep 14, 2016

Closed

Replace SAMFileReader with SamReaderFactory #653

@lbergelson lbergelson deleting SAMFileReader and SAMTruncatedFileReader
these long deprecated classes were intended to be deleted in #602 but were accidentally resurrected
  updated documentation to point to SamReader instead of SAMFileReader

renamed SAMFileReaderTest to the more accurate SamReaderTest
a0e259f
Contributor

lbergelson commented Sep 14, 2016

@droazen Opened issues and rebased this. Should we wait for them to be resolved or merge this before that happens?

Coverage Status

Coverage increased (+0.5%) to 69.458% when pulling a0e259f on lb_redelete_deprecated_reader into 255e41a on master.

Contributor

droazen commented Sep 14, 2016

@lbergelson I'd say wait until the Picard one is merged, since it's simple, but don't wait for GATK3.

magicDGS referenced this pull request Sep 21, 2016

Merged

Clean some deprecated classes/methods usages in htsjdk #707

3 of 5 tasks complete
Contributor

lbergelson commented Oct 24, 2016

Uses were removed from both GATK and Picard so I'm going to merge this.

@lbergelson lbergelson merged commit 7ab2531 into master Oct 24, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 69.458%
Details

lbergelson deleted the lb_redelete_deprecated_reader branch Oct 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment