Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Added a secondary constructor to IntervalList that takes a dict. #703
Conversation
coveralls
commented
Sep 12, 2016
|
Why a private method in |
|
@magicDGS I wanted the secondary constructor there. It's ~3 lines of simple code - I don't think it warrants extracting to a separate utility class. |
|
Also, yay, SRA tests are failing. |
droazen
self-assigned this
Sep 13, 2016
|
I've found myself sometimes having to go from Also, add a simple unit test so we have test coverage on the new constructor(s). |
|
Review complete, back to @tfenne |
droazen
assigned tfenne and unassigned droazen
Sep 13, 2016
|
Sure @droazen I can do that instead. I wasn't sure there were other uses for it. I'll swap that around then merge. |
tfenne commentedSep 12, 2016
Description
I find myself writing these three lines of code again and again and again to initialize an IntervalList since it requires a
SAMFileHeaderwith a usefulSAMSequenceDictionaryand there's no way to create a header from a dictionary as an expression.Checklist