Adding delta for getTime assert to fix #578 #710

Merged
merged 1 commit into from Oct 24, 2016

Conversation

Projects
None yet
4 participants
Contributor

magicDGS commented Sep 17, 2016

Description

After overhaul the tests in RelativeIso8601DateTest because of test failures due to #578, I found that some of the getTime() asserts does not contain a delta value when one of them does. Thus, I added a delta value for all the tests to try to solve this issue.

Because the test failure is not deterministic, I don't know how to tests this. But at least it is a good practice to test always with the same delta value. This is a very simple patch that does not change anything important in the code.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

Coverage Status

Coverage remained the same at 68.995% when pulling ce371d3 on magicDGS:dgs_fix_578 into fbba536 on samtools:master.

@magicDGS @magicDGS magicDGS adding delta for getTime assert to fix #578
34931c3

Coverage Status

Coverage remained the same at 69.04% when pulling 34931c3 on magicDGS:dgs_fix_578 into 88b6719 on samtools:master.

Contributor

yfarjoun commented Sep 22, 2016

👍

@lbergelson lbergelson merged commit b497630 into samtools:master Oct 24, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 69.04%
Details
Contributor

lbergelson commented Oct 24, 2016

thanks @magicDGS! (I was away on paternity leave, going to get to your long delayed PR's in the near future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment