Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Adding delta for getTime assert to fix #578 #710
Conversation
coveralls
commented
Sep 17, 2016
coveralls
commented
Sep 21, 2016
|
|
lbergelson
merged commit b497630
into
samtools:master
Oct 24, 2016
|
thanks @magicDGS! (I was away on paternity leave, going to get to your long delayed PR's in the near future) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
magicDGS commentedSep 17, 2016
Description
After overhaul the tests in
RelativeIso8601DateTestbecause of test failures due to #578, I found that some of thegetTime()asserts does not contain a delta value when one of them does. Thus, I added a delta value for all the tests to try to solve this issue.Because the test failure is not deterministic, I don't know how to tests this. But at least it is a good practice to test always with the same delta value. This is a very simple patch that does not change anything important in the code.
Checklist