updating the gradle version from 2.13 to 3.2.1 #727

Merged
merged 2 commits into from Dec 14, 2016

Conversation

Projects
None yet
4 participants
Contributor

lbergelson commented Oct 21, 2016 edited

Description

updating from gradle 2.13 -> 3.1
adding a settings.gradle file to define the project name

these changes make it possible to use htsjdk in a composite gradle build with other projects

This will make changes to downstream projects that require updates to htsjdk easier to develop and test. Experimental builds of intellij are including a composite build feature and these changes are necessary to use it.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

droazen was assigned by lbergelson Oct 21, 2016

Coverage Status

Coverage remained the same at 69.04% when pulling e6ad966 on lb_udpate_to_gradle_3.1 into 88b6719 on master.

Contributor

yfarjoun commented Oct 27, 2016

will this affect downstream projects (like picard) that have not upgraded their gradle?

Contributor

lbergelson commented Oct 27, 2016

@yfarjoun It won't affect any downstream projects that use the artifacts produced by the build. If they actually call into the gradle build directly there's a possibility that it will be affected. I would be surprised if there were any problems though, I don't think we make use of any features that would have changed between 2 and 3.

Once all the projects in the ecosystem are on 3.1+ it will let us do some nice things, like have intellij manage them as if they were a single build. (I.e. both projects open in intellij, change something in htsjdk and see immediate changes in picard like it used to be, but still keep the releases separated.)

Contributor

lbergelson commented Oct 27, 2016

I'm running a build of picard master against this branch just to be check . https://gatk-jenkins.broadinstitute.org/job/picard-on-htsjdk-master/390/

Contributor

lbergelson commented Nov 22, 2016

@yfarjoun 👍 / 👎 ?

Contributor

yfarjoun commented Nov 23, 2016 edited

is 3.1 "cutting edge"? I want to make sure we are using a stable version of gradle.

Contributor

lbergelson commented Nov 28, 2016

3.1 is actually outdated now. We should probably update to 3.2.1 which is supposed to make IDE integration performance better. 3.1 is the minimum version necessary to use the incredibly useful composite build support though.

droazen referenced this pull request Nov 29, 2016

Open

Review "Party" #548

Coverage Status

Coverage increased (+1.0%) to 70.027% when pulling 2dee515 on lb_udpate_to_gradle_3.1 into 88b6719 on master.

Contributor

yfarjoun commented Dec 5, 2016

why did coverage go up?

Contributor

lbergelson commented Dec 5, 2016

@yfarjoun Not sure... Coveralls bug is my assumption. I think coveralls is showing coverage based on the push branch instead of the pull request one. I wouldn't worry about.

Contributor

lbergelson commented Dec 5, 2016

(part of why I want to switch to codecov, #764 )

lbergelson changed the title from updating the gradle version from 2.13 to 3.1 to updating the gradle version from 2.13 to 3.2.1 Dec 13, 2016

lbergelson added some commits Oct 21, 2016

@lbergelson lbergelson updating the gradle version from 2.13 to 3.1
adding a settings.gradle file to define the project name
these changes make it possible to use htsjdk in a composit gradle build with other projects
aa87b9f
@lbergelson lbergelson updating to 3.2.1
94e584b

Coverage Status

Coverage increased (+0.006%) to 70.554% when pulling 94e584b on lb_udpate_to_gradle_3.1 into 2386a6e on master.

Contributor

lbergelson commented Dec 14, 2016

@yfarjoun picard-private tests pass with this

@lbergelson lbergelson merged commit c795101 into master Dec 14, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 70.554%
Details

lbergelson deleted the lb_udpate_to_gradle_3.1 branch Dec 14, 2016

@superbobry superbobry added a commit to superbobry/htsjdk that referenced this pull request Dec 25, 2016

@lbergelson @superbobry lbergelson + superbobry updating the gradle version from 2.13 to 3.2.1 (#727)
updating the gradle version from 2.13 to 3.2.1
adding a settings.gradle file to define the project name

these changes make it possible to use htsjdk in a composite gradle build with other projects
db57898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment