Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Yf fix test removed deprecated methods relating to nm #728
Conversation
jacarey
was assigned
by yfarjoun
Oct 21, 2016
coveralls
commented
Oct 21, 2016
| @@ -985,66 +903,63 @@ public static void calculateMdAndNmTags(final SAMRecord record, final byte[] ref | ||
| final Cigar cigar = record.getCigar(); |
|
|
|
waiting for tests to pass, then merging. |
coveralls
commented
Oct 24, 2016
yfarjoun
merged commit 58f4154
into
master
Oct 24, 2016
yfarjoun
deleted the
yf_fix_test_removed_deprecated_methods_relating_to_NM branch
Oct 24, 2016
yfarjoun
referenced
this pull request
Nov 20, 2016
Closed
Remove deprecated methods in SequenceUtil #330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
yfarjoun commentedOct 21, 2016
•
edited
Description
Bug in SequenceUtil.calculateMdAndNmTags() whereby bases with different case (upper/lower) in reference or read are considered different despite the sam-spec saying that regarding SEQ: "No assumptions can be made on the letter cases." This has caused validatino problems for files that had their NM values set via SequenceUtil.calculateMdAndNmTags() (which takes case into account) and validated via SequenceUtil.calculateSamNmTag() (which, correctly, ignores case)
This PR fixes calculateMdAndNmTags by the same mechanism as used by calculateSamNmTag, adds a test to both functions (also testing MD at the same time) and gives variables in calculateMdAndNmTags more meaningful names.
Also, while I'm there I removed several deprecated functions that are not used.
I would like to nominate @jacarey for review as he seems to be the original author of calculateSamNmTag.
Checklist