automatically adding @Override annotations #729

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
4 participants
Contributor

lbergelson commented Oct 21, 2016 edited

Description

added the @Override annotation everywhere it was missing using auto inspection

also cleaned up a few typos in LittleEndianOutputStream and made a protected variable private since it's a final class

The lack of @Override annotations was annoying me so I just had intellij fix them all. Maybe it will prevent future bugs do to ham-fisted refactorings.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

droazen was assigned by lbergelson Oct 21, 2016

Coverage Status

Coverage remained the same at 69.04% when pulling ab3f269 on lb_adding_missing_override_annotations into 88b6719 on master.

Coverage Status

Coverage remained the same at 70.027% when pulling 39bc560 on lb_adding_missing_override_annotations into 6e4e875 on master.

Coverage Status

Coverage remained the same at 70.027% when pulling 6a60687 on lb_adding_missing_override_annotations into 6e4e875 on master.

Contributor

droazen commented Dec 1, 2016

👍 merge after confirming that the only changes here are the addition of the @Overrides

@droazen droazen assigned lbergelson and unassigned droazen Dec 1, 2016

@lbergelson lbergelson automatically adding @Override annotations
added the @Override annotation everywhere it was missing using autoinspection
b964598

Codecov Report

Merging #729 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #729      +/-   ##
============================================
- Coverage     64.84%   64.84%   -0.01%     
  Complexity     7160     7160              
============================================
  Files           525      525              
  Lines         31701    31701              
  Branches       5420     5420              
============================================
- Hits          20558    20556       -2     
- Misses         8994     8996       +2     
  Partials       2149     2149
Impacted Files Coverage Δ Complexity Δ
...ain/java/htsjdk/samtools/util/DiskBackedQueue.java 64.81% <ø> (ø) 29 <ø> (ø)
src/main/java/htsjdk/variant/vcf/VCFCodec.java 65.9% <ø> (ø) 13 <ø> (ø)
...dk/samtools/cram/encoding/huffman/HuffmanTree.java 75% <ø> (ø) 1 <ø> (ø)
...tsjdk/samtools/cram/io/DefaultBitOutputStream.java 44.31% <ø> (ø) 12 <ø> (ø)
...va/htsjdk/variant/vcf/VCFHeaderLineTranslator.java 87.5% <ø> (ø) 2 <ø> (ø)
...tsjdk/samtools/util/Md5CalculatingInputStream.java 0% <ø> (ø) 0 <ø> (ø)
...main/java/htsjdk/samtools/BinningIndexContent.java 66.19% <ø> (ø) 13 <ø> (ø)
...tsjdk/tribble/readers/TabixIteratorLineReader.java 57.14% <ø> (ø) 3 <ø> (ø)
...main/java/htsjdk/variant/vcf/AbstractVCFCodec.java 72.58% <ø> (ø) 88 <ø> (ø)
...va/htsjdk/samtools/filter/DuplicateReadFilter.java 66.66% <ø> (ø) 2 <ø> (ø)
... and 151 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cabe78f...b964598. Read the comment docs.

@lbergelson lbergelson merged commit 912c28b into master Feb 21, 2017

3 of 4 checks passed

codecov/project 64.84% (-0.01%) compared to cabe78f
Details
codecov/patch Coverage not affected when comparing cabe78f...b964598
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

lbergelson deleted the lb_adding_missing_override_annotations branch Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment