Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
automatically adding @Override annotations #729
+583
−2
Conversation
droazen
was assigned
by lbergelson
Oct 21, 2016
coveralls
commented
Oct 21, 2016
coveralls
commented
Nov 29, 2016
coveralls
commented
Nov 29, 2016
|
|
droazen
assigned lbergelson and unassigned droazen
Dec 1, 2016
codecov-io
commented
Feb 21, 2017
Codecov Report
@@ Coverage Diff @@
## master #729 +/- ##
============================================
- Coverage 64.84% 64.84% -0.01%
Complexity 7160 7160
============================================
Files 525 525
Lines 31701 31701
Branches 5420 5420
============================================
- Hits 20558 20556 -2
- Misses 8994 8996 +2
Partials 2149 2149
Continue to review full report at Codecov.
|
lbergelson
merged commit 912c28b
into
master
Feb 21, 2017
3 of 4 checks passed
lbergelson
deleted the
lb_adding_missing_override_annotations branch
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
lbergelson commentedOct 21, 2016
•
edited
Description
added the
@Overrideannotation everywhere it was missing using auto inspectionalso cleaned up a few typos in LittleEndianOutputStream and made a protected variable private since it's a final class
The lack of
@Overrideannotations was annoying me so I just had intellij fix them all. Maybe it will prevent future bugs do to ham-fisted refactorings.Checklist