/htsjdk

Change default logging level to INFO #740

Merged
merged 1 commit into from Nov 10, 2016
+1 −1

Conversation

Reviewers
No reviews
Assignees

@vdauwera vdauwera

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ronlevine @coveralls @vdauwera
@ronlevine
Contributor

ronlevine commented Nov 8, 2016

Description

Implements #739.
Do not want to get DEBUG messages by default.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
@ronlevine ronlevine Change default logging level to INFO

All checks have passed

3 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.006%) to 69.839%
Details
2e6643b

vdauwera was assigned by ronlevine Nov 8, 2016

@ronlevine
Contributor

ronlevine commented Nov 8, 2016

@vdauwera Please review.
@coveralls

coveralls commented Nov 8, 2016

Coverage Status

Coverage decreased (-0.006%) to 69.839% when pulling 2e6643b on rhl_log_info_739 into 1c66107 on master.
@vdauwera
Contributor

vdauwera commented Nov 8, 2016

Looks good to me.

Anybody out there have strong opinions about this change, before we merge?
@ronlevine
Contributor

ronlevine commented Nov 8, 2016

@vdauwera Going once, going twice, merge?
@vdauwera
Contributor

vdauwera commented Nov 8, 2016

Maybe give people until tomorrow, unless there's an imminent release?
@ronlevine
Contributor

ronlevine commented Nov 10, 2016

@vdauwera How about you merge when you feel the time is right...
@vdauwera
Contributor

vdauwera commented Nov 10, 2016

Yeah no one has piped up...

@ronlevine ronlevine merged commit 70783fc into master Nov 10, 2016
3 checks passed

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 69.839%
Details

ronlevine deleted the rhl_log_info_739 branch Nov 10, 2016

This was referenced Nov 15, 2016

Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment