/htsjdk

Missing license header added to the following classes: SamInputResour… #742

Merged
merged 1 commit into from Nov 19, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mzueva @coveralls @yfarjoun
@mzueva
Contributor

mzueva commented Nov 16, 2016 • edited

Some significant htsjdk classes are missing the license header. This Pull requests adds a missing license to 4 classes:

  • htsjdk.samtools.SamInputResource

  • htsjdk.samtools.SamReader

  • htsjdk.samtools.SamReaderFactory

  • htsjdk.samtools.seekablestream.ByteArraySeekableStream

  • Code compiles correctly

  • New tests covering changes and new functionality

  • All tests passing

  • Extended the README / documentation, if necessary

  • Is not backward compatible (breaks binary or source compatibility
@mzueva mzueva Missing license header added to the following classes: SamInputResour… 
…ce, SamReader, SamReaderFactory, ByteArraySeekableStream

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.006%) to 69.833%
Details
2c3c8a2
@coveralls

coveralls commented Nov 16, 2016

Coverage Status

Coverage decreased (-0.006%) to 69.833% when pulling 2c3c8a2 on EpamLifeSciencesTeam:epam_licenses_added into 70783fc on samtools:master.
@yfarjoun
Contributor

yfarjoun commented Nov 19, 2016

thanks! 👍

@yfarjoun yfarjoun merged commit 8e7fe7a into samtools:master Nov 19, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 69.833%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment