Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Increased test coverage for SamFileValidator #743
Conversation
coveralls
commented
Nov 16, 2016
|
Thanks! |
yfarjoun
merged commit 398c0ee
into
samtools:master
Nov 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ekazachkova commentedNov 16, 2016
Increased test coverage for SamFileValidator
We represent PR that contains increased test coverage for
SamFileValidatorclass with the following changes inValidateSamFileTest:executeValidationmethodvalidateBamFileTerminationmethodAlso, we suggest the following changes in
SamFileValidatorclass:SamFileValidator's fields by constructor instead of using default valueserrorsByTypefield with package access for testing.Checklist