Increased test coverage for SamFileValidator #743

Merged
merged 1 commit into from Nov 19, 2016

Conversation

Projects
None yet
3 participants
Contributor

ekazachkova commented Nov 16, 2016

Increased test coverage for SamFileValidator

We represent PR that contains increased test coverage for SamFileValidator class with the following changes in ValidateSamFileTest:

  • Make simple refactoring for executeValidation method
  • Add new test for validateBamFileTermination method
  • Add new test and new data provider for validating E2 tag and U2 tag process correctness.

Also, we suggest the following changes in SamFileValidator class:

  • Initialize SamFileValidator's fields by constructor instead of using default values
  • Add getter for errorsByType field with package access for testing.

Checklist

  • Code compiles correctly
  • New tests covering changes
  • All tests passing
@ekazachkova ekazachkova test coverage for SamFileValidator
be0d66c

Coverage Status

Coverage increased (+0.1%) to 69.938% when pulling be0d66c on EpamLifeSciencesTeam:epam-ls_test_coverage_SamFileValidator into 70783fc on samtools:master.

Contributor

yfarjoun commented Nov 19, 2016

Thanks! 👍

@yfarjoun yfarjoun merged commit 398c0ee into samtools:master Nov 19, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 69.938%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment