/htsjdk

Public CustomGzipOutputStream #746

Merged
merged 1 commit into from Nov 22, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@magicDGS @coveralls @lbergelson
@magicDGS
Contributor

magicDGS commented Nov 20, 2016 • edited

Description

There is a CustomGzipOutputStream in HTSJDK for setting the compression level at construction, which is used in IOUtils.openGzipFileForWriting(File file, boolean append). But if you want to wrap an OutputStream from other sources (like a Path) using the Defaults.COMPRESSION_LEVEL or other compression, it is impossible to set unless this class is coded again.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
@magicDGS magicDGS make CustomGzipOutputStream public to be able to set compression level

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 69.972%
Details
535a8e1
@coveralls

coveralls commented Nov 20, 2016

Coverage Status

Coverage remained the same at 69.972% when pulling 535a8e1 on magicDGS:dgs_public_CustomGzipOutputStream into 5ddddde on samtools:master.
@lbergelson
Contributor

lbergelson commented Nov 22, 2016

👍 seems reasonable to me

@lbergelson lbergelson merged commit 24c65a1 into samtools:master Nov 22, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 69.972%
Details
@magicDGS
Contributor

magicDGS commented Nov 23, 2016

Thanks @lbergelson!

magicDGS referenced this pull request Feb 10, 2017

Merged

Make public constructors in CustomGzipOutputStream #798

2 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment