/htsjdk

Removing TribbleIndexedFeatureReader.isGZIPPath deprecated method #752

Merged
merged 1 commit into from Jan 10, 2017

Conversation

Reviewers

@droazen droazen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@magicDGS @coveralls @droazen
@magicDGS
Contributor

magicDGS commented Nov 24, 2016 • edited

Description

Removed unused package-specific (visible for testing) deprecated method. Found in #707.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
@magicDGS magicDGS removing unused package-specific (visible for testing) deprecated method

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.006%) to 70.013%
Details
83cc423
@coveralls

coveralls commented Nov 24, 2016

Coverage Status

Coverage increased (+0.006%) to 70.013% when pulling 83cc423 on magicDGS:dgs_remove_unused_isGZIPPath into de27f18 on samtools:master.
src/test/java/htsjdk/tribble/TribbleIndexFeatureReaderTest.java
- public void testGZExtension(final String testString, final boolean expected) throws URISyntaxException {
- Assert.assertEquals(TribbleIndexedFeatureReader.isGZIPPath(testString), expected);
- }
-
@droazen

droazen Jan 10, 2017

Contributor

Can we keep these tests, and alter them to test hasBlockCompressedExtension(String) instead?

@droazen

droazen Jan 10, 2017

Contributor

Never mind, I see that we already have tests in AbstractFeatureReaderTest

@droazen droazen merged commit ed15dc0 into samtools:master Jan 10, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 70.013%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment