Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
refactoring Lazy to take a Supplier() #780
Conversation
|
@yfarjoun I noticed that we had this pointless class. I deprecated it. It should be backwards compatible with existing code. |
lbergelson
requested a review
from yfarjoun
Jan 5, 2017
yfarjoun
was assigned
by lbergelson
Jan 5, 2017
codecov-io
commented
Jan 5, 2017
•
Current coverage is 63.980% (diff: 91.667%)@@ master #780 diff @@
==========================================
Files 527 527
Lines 31733 32124 +391
Methods 0 0
Messages 0 0
Branches 6786 6921 +135
==========================================
+ Hits 20256 20553 +297
- Misses 9335 9417 +82
- Partials 2142 2154 +12
|
|
|
lbergelson
merged commit dc179c1
into
master
Jan 10, 2017
4 of 5 checks passed
codecov/changes
5 files have unexpected coverage changes not visible in diff.
Details
codecov/patch
91.667% of diff hit (target 63.833%)
Details
codecov/project
63.980% (+0.148%) compared to ed15dc0
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
lbergelson
deleted the
lb_refactor_lazy_to_use_supplier branch
Jan 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
lbergelson commentedJan 5, 2017
Description
Lazy previously accepted a custom interface called LazyInitializer which is redundant with Supplier since java 8
made LazyInitializer extend Supplier
changed the constructor to take generic Supplier instead of only LazyInitializers
Checklist