refactoring Lazy to take a Supplier() #780

Merged
merged 1 commit into from Jan 10, 2017

Conversation

Projects
None yet
3 participants
Contributor

lbergelson commented Jan 5, 2017

Description

Lazy previously accepted a custom interface called LazyInitializer which is redundant with Supplier since java 8

made LazyInitializer extend Supplier
changed the constructor to take generic Supplier instead of only LazyInitializers

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
Contributor

lbergelson commented Jan 5, 2017

@yfarjoun I noticed that we had this pointless class. I deprecated it. It should be backwards compatible with existing code.

lbergelson requested a review from yfarjoun Jan 5, 2017

yfarjoun was assigned by lbergelson Jan 5, 2017

codecov-io commented Jan 5, 2017 edited

Current coverage is 63.980% (diff: 91.667%)

Merging #780 into master will increase coverage by 0.148%

@@             master       #780   diff @@
==========================================
  Files           527        527          
  Lines         31733      32124   +391   
  Methods           0          0          
  Messages          0          0          
  Branches       6786       6921   +135   
==========================================
+ Hits          20256      20553   +297   
- Misses         9335       9417    +82   
- Partials       2142       2154    +12   

Sunburst

Diff Coverage File Path
•••••• 66% src/main/java/htsjdk/samtools/util/Lazy.java
•••••••••• 100% src/main/java/htsjdk/samtools/SamInputResource.java
•••••••••• 100% ...sjdk/variant/variantcontext/VariantContextUtils.java

Powered by Codecov. Last update ed15dc0...667e9c5

Contributor

yfarjoun commented Jan 8, 2017

👍

@lbergelson lbergelson refactoring Lazy to take a Supplier()
it previously accepted a custom interface called LazyInitializer which is redundant with Supplier since java 8

made LazyInitializer extend Supplier
changed the constructor to take generic Supplier instead of only LazyInitializers
667e9c5

@lbergelson lbergelson merged commit dc179c1 into master Jan 10, 2017

4 of 5 checks passed

codecov/changes 5 files have unexpected coverage changes not visible in diff.
Details
codecov/patch 91.667% of diff hit (target 63.833%)
Details
codecov/project 63.980% (+0.148%) compared to ed15dc0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

lbergelson deleted the lb_refactor_lazy_to_use_supplier branch Jan 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment