/htsjdk

Fixed unmappable character for encoding ASCII #784

Merged
merged 1 commit into from Jan 11, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@magicDGS @yfarjoun @codecov-io
@magicDGS
Contributor

magicDGS commented Jan 11, 2017

Description

Fix #783.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
@magicDGS magicDGS fixed unmappable character for encoding ASCII

Some checks were not successful

1 failing and 3 successful checks
codecov/changes — 2 files have unexpected coverage changes not visible in diff.
Details
codecov/patch — Coverage not affected when comparing dc179c1...441b794
Details
codecov/project — Absolute coverage decreased by -0.009% but relative coverage increased by +36.112% compared to dc179c1
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
441b794
@magicDGS
Contributor

magicDGS commented Jan 11, 2017

I'm sorry for this, my IDE is applying copyright templates by default. Can you have a look, @yfarjoun? I search other sources for this, but I didn't find anything, so it should be fine.
@yfarjoun
Contributor

yfarjoun commented Jan 11, 2017

👍

@yfarjoun yfarjoun merged commit 5a9d819 into samtools:master Jan 11, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@codecov-io

codecov-io commented Jan 11, 2017

Current coverage is 63.878% (diff: 100%)

Merging #784 into master will decrease coverage by 0.009%

@@             master       #784   diff @@
==========================================
  Files           523        523          
  Lines         31643      31643          
  Methods           0          0          
  Messages          0          0          
  Branches       6766       6766          
==========================================
- Hits          20216      20213     -3   
- Misses         9291       9293     +2   
- Partials       2136       2137     +1

Sunburst

Powered by Codecov. Last update dc179c1...441b794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment