Add getters for defaults SAMFileWriterFactory fields #791

Merged
merged 1 commit into from Jan 25, 2017

Conversation

Projects
None yet
3 participants
Contributor

magicDGS commented Jan 25, 2017

Description

Simple PR for retrieve the defaults that were set in the SAMFileWriterFactoryclass.

Motivation: API clients may want to request which defaults were set for re-use then in other classes or log them.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
@magicDGS magicDGS Add getters for defaults SAMFileWriterFactory fields
eb97097

Current coverage is 64.540% (diff: 0.000%)

Merging #791 into master will decrease coverage by 0.004%

@@             master       #791   diff @@
==========================================
  Files           523        523          
  Lines         31614      31616     +2   
  Methods           0          0          
  Messages          0          0          
  Branches       6769       6769          
==========================================
  Hits          20405      20405          
- Misses         9063       9065     +2   
  Partials       2146       2146          

Sunburst

Diff Coverage File Path
0% .../main/java/htsjdk/samtools/SAMFileWriterFactory.java

Powered by Codecov. Last update 19bd848...eb97097

Contributor

lbergelson commented Jan 25, 2017

👍

@lbergelson lbergelson merged commit 4231660 into samtools:master Jan 25, 2017

1 of 4 checks passed

codecov/changes 1 file has unexpected coverage changes not visible in diff.
Details
codecov/patch 0.000% of diff hit (target 64.544%)
Details
codecov/project 64.540% (-0.004%) compared to 19bd848
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Contributor

magicDGS commented Jan 25, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment