/htsjdk

Don't set a custom default InflaterFactory when testing passing in an explicit InflaterFactory #795

Merged
merged 1 commit into from Feb 1, 2017

Conversation

Reviewers

@lbergelson lbergelson

Assignees

@lbergelson lbergelson

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@droazen @codecov-io @lbergelson
@droazen
Contributor

droazen commented Feb 1, 2017

No description provided.

@droazen
Contributor

droazen commented Feb 1, 2017

Quickie for @lbergelson

lbergelson was assigned by droazen Feb 1, 2017

@codecov-io

codecov-io commented Feb 1, 2017 • edited

Codecov Report

Merging #795 into master will increase coverage by -0.009%.

@@               Coverage Diff               @@
##              master      #795       +/-   ##
===============================================
- Coverage     64.572%   64.562%   -0.009%     
===============================================
  Files            524       524               
  Lines          31667     31667               
  Branches        5415      5415               
===============================================
- Hits           20448     20445        -3     
- Misses          9076      9078        +2     
- Partials        2143      2144        +1
Impacted Files Coverage Δ Complexity Δ
...sjdk/samtools/util/Md5CalculatingOutputStream.java 70.27% <ø> (-8.108%) 0% <ø> (-8%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34440b7...e1bd6cf. Read the comment docs.
@droazen droazen Don't set a custom default InflaterFactory when testing passing in an… 
… explicit InflaterFactory

Otherwise, the tests for passing in an explicit factory are not valid.

Some checks were not successful

2 failing and 3 successful checks
codecov/changes — 1 file has unexpected coverage changes not visible in diff.
Details
codecov/project — 64.562% (-0.009%) compared to 34440b7
Details
codecov/patch — Coverage not affected when comparing 34440b7...e1bd6cf
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
e1bd6cf
@lbergelson

lbergelson approved these changes Feb 1, 2017
View changes

👍

@droazen droazen merged commit 991a8e4 into master Feb 1, 2017
3 of 5 checks passed

3 of 5 checks passed

codecov/changes 1 file has unexpected coverage changes not visible in diff.
Details
codecov/project 64.562% (-0.009%) compared to 34440b7
Details
codecov/patch Coverage not affected when comparing 34440b7...e1bd6cf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

droazen deleted the dr_separate_default_from_custom_inflaterfactory_tests branch Feb 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment