Make public constructors in CustomGzipOutputStream #798

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
Contributor

magicDGS commented Feb 10, 2017

Description

I made public the CustomGzipOutputStream in #746 to use it outside IOUtils, but I forgot to made the constructors public too. This fix the problem and makes the custom gzip wrapper available for use it outside the package.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
@magicDGS magicDGS Make public constructors in CustomGzipOutputStream
9264428
Contributor

magicDGS commented Feb 10, 2017

You accepted my previous PR, @lbergelson... could you have a look to this one?

Contributor

lbergelson commented Feb 10, 2017

@magicDGS 👍

@lbergelson lbergelson merged commit 18508d4 into samtools:master Feb 10, 2017

2 of 4 checks passed

codecov/changes 3 files have unexpected coverage changes not visible in diff.
Details
codecov/project 64.737% (-0.013%) compared to 7ef0a84
Details
codecov/patch Coverage not affected when comparing 7ef0a84...9264428
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Contributor

magicDGS commented Feb 10, 2017

Thanks!

@vadimzalunin vadimzalunin added a commit to vadimzalunin/htsjdk that referenced this pull request Mar 14, 2017

@magicDGS @vadimzalunin magicDGS + vadimzalunin Make constructors public in CustomGzipOutputStream (#798) 037b89b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment