fixing vararg warnings on test compilation #809

Merged
merged 2 commits into from Mar 7, 2017

Conversation

Projects
None yet
3 participants
Contributor

lbergelson commented Feb 27, 2017

fixing the 4 annoying warnings that pop up whenever you compile tests

I also added a test case that seems to have been accidentally forgotten, the variable was constructed but not added to the dataprovider.

the first commit just fixes the extraneous , the second commit has the casts and the extra test case

lbergelson added some commits Feb 27, 2017

@lbergelson lbergelson fix <> on VariantContextUnitTest b19a46f
@lbergelson lbergelson fixing ambiguous varargs call wranings in VariantContextUnitTest
explicitely casting null values to resolve warnings
adding a test case that seems to been accidentally missed
7cb78dd

Codecov Report

Merging #809 into master will decrease coverage by -0.009%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master      #809       +/-   ##
===============================================
- Coverage     64.867%   64.858%   -0.009%     
+ Complexity      7175      7174        -1     
===============================================
  Files            526       526               
  Lines          31731     31731               
  Branches        5424      5424               
===============================================
- Hits           20583     20580        -3     
- Misses          9000      9002        +2     
- Partials        2148      2149        +1
Impacted Files Coverage Δ Complexity Δ
...sjdk/samtools/util/Md5CalculatingOutputStream.java 70.27% <0%> (-8.108%) 7% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1227d8...7cb78dd. Read the comment docs.

Contributor

droazen commented Mar 7, 2017

👍 merge when ready

lbergelson was assigned by droazen Mar 7, 2017

@lbergelson lbergelson merged commit 9ab5518 into master Mar 7, 2017

4 of 5 checks passed

codecov/changes 1 file has unexpected coverage changes not visible in diff.
Details
codecov/patch Coverage not affected when comparing c1227d8...7cb78dd
Details
codecov/project 64.858% (-0.009%) compared to c1227d8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

lbergelson deleted the lb_fix_annoying_warnings_on_testcompile branch Mar 7, 2017

@magicDGS magicDGS added a commit to magicDGS/htsjdk that referenced this pull request Mar 8, 2017

@lbergelson @magicDGS lbergelson + magicDGS fixing vararg warnings on test compilation (#809)
* fix <> on VariantContextUnitTest
* fixing ambiguous varargs call warnings in VariantContextUnitTest
      explicitly casting null values to resolve warnings
* adding a test case that seems to been accidentally missed
8d61256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment