Md5CalculatingOutputStream support for Path #814

Merged
merged 1 commit into from Mar 3, 2017

Conversation

Projects
None yet
3 participants
Contributor

magicDGS commented Mar 2, 2017 edited

Description

Very simple patch to allow writing the MD5 digest file to a path.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
@magicDGS magicDGS Md5CalculatingOutputStream support for Path
544c2d7

Codecov Report

Merging #814 into master will decrease coverage by -0.014%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##              master      #814       +/-   ##
===============================================
- Coverage     64.867%   64.854%   -0.014%     
+ Complexity      7175      7173        -2     
===============================================
  Files            526       526               
  Lines          31731     31733        +2     
  Branches        5424      5424               
===============================================
- Hits           20583     20580        -3     
- Misses          9000      9002        +2     
- Partials        2148      2151        +3
Impacted Files Coverage Δ Complexity Δ
...sjdk/samtools/util/Md5CalculatingOutputStream.java 71.795% <100%> (-6.584%) 8 <1> (ø)
...main/java/htsjdk/samtools/SAMRecordSetBuilder.java 88.306% <0%> (-0.806%) 62% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1227d8...544c2d7. Read the comment docs.

Contributor

magicDGS commented Mar 2, 2017

This is a very simple patch to be able to use the MD5 calculation wrapper with a Path. Can you review, @lbergelson? I'm asking you because you also took #810 (path support for other classes).

magicDGS referenced this pull request in magicDGS/ReadTools Mar 3, 2017

Closed

Use the Path constructor for Md5CalculatingOutputStream #142

Contributor

lbergelson commented Mar 3, 2017

@magicDGS 👍

@lbergelson lbergelson merged commit 737ceec into samtools:master Mar 3, 2017

3 of 4 checks passed

codecov/changes 2 files have unexpected coverage changes not visible in diff.
Details
codecov/patch 100% of diff hit (target 64.867%)
Details
codecov/project Absolute coverage decreased by -0.014% but relative coverage increased by +35.133% compared to c1227d8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Contributor

magicDGS commented Mar 3, 2017

Thanks!

magicDGS deleted the magicDGS:dgs_Md5CalculatingOutputStream_path branch Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment