Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixed bug where calling IntervalList.uniqued(false) would fail if the… #815
Conversation
tfenne
requested a review
from yfarjoun
Mar 2, 2017
|
@yfarjoun Tiny PR, mind taking a look for me? |
codecov-io
commented
Mar 2, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #815 +/- ##
===============================================
+ Coverage 64.867% 64.869% +0.002%
- Complexity 7175 7176 +1
===============================================
Files 526 526
Lines 31731 31730 -1
Branches 5424 5424
===============================================
Hits 20583 20583
+ Misses 9000 8999 -1
Partials 2148 2148
Continue to review full report at Codecov.
|
tfenne
merged commit c677380
into
master
Mar 2, 2017
4 of 5 checks passed
codecov/changes
1 file has unexpected coverage changes not visible in diff.
Details
codecov/patch
100% of diff hit (target 64.867%)
Details
codecov/project
64.869% (+0.002%) compared to c1227d8
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
tfenne
deleted the
tf_fix_intervalist_uniqued branch
Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tfenne commentedMar 2, 2017
… interval names were null.
Description
IntervalList.uniqued(false)would throw an exception if called on Interval objects that had null names (which is allowed).Checklist