Fixed bug where calling IntervalList.uniqued(false) would fail if the… #815

Merged
merged 1 commit into from Mar 2, 2017

Conversation

Projects
None yet
3 participants
Owner

tfenne commented Mar 2, 2017

… interval names were null.

Description

IntervalList.uniqued(false) would throw an exception if called on Interval objects that had null names (which is allowed).

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
@tfenne tfenne Fixed bug where calling IntervalList.uniqued(false) would fail if the…
… interval names were null.
b701f1a

tfenne requested a review from yfarjoun Mar 2, 2017

Owner

tfenne commented Mar 2, 2017

@yfarjoun Tiny PR, mind taking a look for me?

codecov-io commented Mar 2, 2017 edited

Codecov Report

Merging #815 into master will increase coverage by 0.002%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##              master      #815       +/-   ##
===============================================
+ Coverage     64.867%   64.869%   +0.002%     
- Complexity      7175      7176        +1     
===============================================
  Files            526       526               
  Lines          31731     31730        -1     
  Branches        5424      5424               
===============================================
  Hits           20583     20583               
+ Misses          9000      8999        -1     
  Partials        2148      2148
Impacted Files Coverage Δ Complexity Δ
...c/main/java/htsjdk/samtools/util/IntervalList.java 64.789% <100%> (+0.227%) 57 <0> (+1)
...sjdk/samtools/util/Md5CalculatingOutputStream.java 70.27% <0%> (-8.108%) 7% <0%> (-1%)
...samtools/util/AsyncBlockCompressedInputStream.java 76% <0%> (+4%) 13% <0%> (+1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1227d8...b701f1a. Read the comment docs.

@yfarjoun

looks good!

@tfenne tfenne merged commit c677380 into master Mar 2, 2017

4 of 5 checks passed

codecov/changes 1 file has unexpected coverage changes not visible in diff.
Details
codecov/patch 100% of diff hit (target 64.867%)
Details
codecov/project 64.869% (+0.002%) compared to c1227d8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

tfenne deleted the tf_fix_intervalist_uniqued branch Mar 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment