Update javadoc for Feature #818

Merged
merged 2 commits into from Mar 10, 2017

Conversation

Projects
None yet
3 participants
Contributor

magicDGS commented Mar 8, 2017

Description

As pointed out in #813, the Feature interface is meant to be a marker for a Locatable with tribble support. This is a simple documentation patch to:

  1. point out what is the purpose of this class.
  2. add a date note to the deprecation of getChr(). Because of the move to the gradle structure, I cannot pinpoint the exact date of deprecation, but at least we know that is before 2016 May.

The first point is to clarify why tribble is using Feature instead of Locatable (and avoid proposals like #812), and the second is to help in the API evolution (to be able to remove at some point deprecated methods).

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
@magicDGS magicDGS Update javadoc for Feature
8b1d182
Contributor

magicDGS commented Mar 8, 2017

Can you have a look to this, @droazen? I think that with this change it is clear what is the meaning of the Feature class, and we can avoid proposals like mine. Thank you very much!

codecov-io commented Mar 8, 2017 edited

Codecov Report

Merging #818 into master will increase coverage by 0.006%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master      #818       +/-   ##
===============================================
+ Coverage     64.867%   64.873%   +0.006%     
- Complexity      7175      7178        +3     
===============================================
  Files            526       526               
  Lines          31731     31731               
  Branches        5424      5424               
===============================================
+ Hits           20583     20585        +2     
- Misses          8997      8998        +1     
+ Partials        2151      2148        -3
Impacted Files Coverage Δ Complexity Δ
src/main/java/htsjdk/tribble/Feature.java 0% <ø> (ø) 0 <0> (ø)
...va/htsjdk/samtools/util/AsyncBufferedIterator.java 68.478% <0%> (-1.087%) 17% <0%> (ø)
...main/java/htsjdk/samtools/SAMRecordSetBuilder.java 89.113% <0%> (+0.806%) 64% <0%> (+2%)
...a/htsjdk/samtools/cram/encoding/rans/Decoding.java 85.714% <0%> (+3.571%) 12% <0%> (+1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d22658...a1674ee. Read the comment docs.

*/
public interface Feature extends Locatable {
/**
* Return the features reference sequence name, e.g chromosome or contig
- * @deprecated use getContig() instead
+ * @deprecated before 05-2017. Use getContig() instead.
@droazen

droazen Mar 8, 2017

Contributor

"before 05-2017" -> "on 03/2015"

@magicDGS

magicDGS Mar 8, 2017

Contributor

Done.

@@ -27,13 +27,14 @@
import htsjdk.samtools.util.Locatable;
/**
- * Represents a locus on a reference sequence. All Features are expected to return 1-based closed-ended intervals.
+ * Marker interface for locatables with Tribble support.
@droazen

droazen Mar 8, 2017

Contributor

Might make things clearer to add an extra sentence here: "Marker interface for Locatables with Tribble support. A Feature represents a record in a tribble-supported file format."

@magicDGS

magicDGS Mar 8, 2017

Contributor

Done.

Contributor

droazen commented Mar 8, 2017

Thanks for this @magicDGS -- two comments to address, then we can merge this.

droazen closed this Mar 8, 2017

droazen reopened this Mar 8, 2017

droazen self-assigned this Mar 8, 2017

@magicDGS magicDGS Address comments
a1674ee
Contributor

magicDGS commented Mar 8, 2017

Thanks for reviewing, @droazen. Back to you!

Contributor

droazen commented Mar 10, 2017

👍

@droazen droazen merged commit 8c97c99 into samtools:master Mar 10, 2017

3 of 4 checks passed

codecov/changes 1 file has unexpected coverage changes not visible in diff.
Details
codecov/patch Coverage not affected when comparing 6d22658...a1674ee
Details
codecov/project 64.873% (+0.006%) compared to 6d22658
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

magicDGS deleted the magicDGS:dgs_feature_javadoc branch Mar 10, 2017

Contributor

magicDGS commented Mar 10, 2017

Thnaks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment