Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update javadoc for Feature #818
Conversation
|
Can you have a look to this, @droazen? I think that with this change it is clear what is the meaning of the |
codecov-io
commented
Mar 8, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
===============================================
+ Coverage 64.867% 64.873% +0.006%
- Complexity 7175 7178 +3
===============================================
Files 526 526
Lines 31731 31731
Branches 5424 5424
===============================================
+ Hits 20583 20585 +2
- Misses 8997 8998 +1
+ Partials 2151 2148 -3
Continue to review full report at Codecov.
|
| */ | ||
| public interface Feature extends Locatable { | ||
| /** | ||
| * Return the features reference sequence name, e.g chromosome or contig | ||
| - * @deprecated use getContig() instead | ||
| + * @deprecated before 05-2017. Use getContig() instead. |
| @@ -27,13 +27,14 @@ | ||
| import htsjdk.samtools.util.Locatable; | ||
| /** | ||
| - * Represents a locus on a reference sequence. All Features are expected to return 1-based closed-ended intervals. | ||
| + * Marker interface for locatables with Tribble support. |
droazen
Mar 8, 2017
Contributor
Might make things clearer to add an extra sentence here: "Marker interface for Locatables with Tribble support. A Feature represents a record in a tribble-supported file format."
|
Thanks for this @magicDGS -- two comments to address, then we can merge this. |
droazen
closed this
Mar 8, 2017
droazen
reopened this
Mar 8, 2017
droazen
self-assigned this
Mar 8, 2017
|
Thanks for reviewing, @droazen. Back to you! |
|
|
droazen
merged commit 8c97c99
into
samtools:master
Mar 10, 2017
3 of 4 checks passed
magicDGS
deleted the
magicDGS:dgs_feature_javadoc branch
Mar 10, 2017
|
Thnaks! |
magicDGS commentedMar 8, 2017
Description
As pointed out in #813, the
Featureinterface is meant to be a marker for aLocatablewith tribble support. This is a simple documentation patch to:getChr(). Because of the move to the gradle structure, I cannot pinpoint the exact date of deprecation, but at least we know that is before 2016 May.The first point is to clarify why tribble is using
Featureinstead ofLocatable(and avoid proposals like #812), and the second is to help in the API evolution (to be able to remove at some point deprecated methods).Checklist