Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix DateParserTest unit tests that were failing in my locale. #832
Conversation
codecov-io
commented
Mar 27, 2017
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
===============================================
+ Coverage 64.864% 64.874% +0.009%
- Complexity 7195 7196 +1
===============================================
Files 527 527
Lines 31774 31774
Branches 5424 5424
===============================================
+ Hits 20610 20613 +3
+ Misses 9016 9014 -2
+ Partials 2148 2147 -1
Continue to review full report at Codecov.
|
|
|
droazen
merged commit 476adb2
into
samtools:master
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Lenbok commentedMar 27, 2017
Description
Several of the DateParserTest unit tests were failing in my locale due to their use of the deprecated Date.parse() method. It seems to me that the existing steps of Date.parse(date.toString()) weren't really accomplishing anything related to htsjdk code (perhaps it was required in past JREs in order to get unix timestamps), so have simplified the assertion to just compare the time stamps directly.
Checklist