Fix DateParserTest unit tests that were failing in my locale. #832

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
3 participants
Contributor

Lenbok commented Mar 27, 2017

Description

Several of the DateParserTest unit tests were failing in my locale due to their use of the deprecated Date.parse() method. It seems to me that the existing steps of Date.parse(date.toString()) weren't really accomplishing anything related to htsjdk code (perhaps it was required in past JREs in order to get unix timestamps), so have simplified the assertion to just compare the time stamps directly.

Checklist

  • Code compiles correctly
  • All tests passing
@Lenbok Lenbok Fix DateParserTest unit tests that were failing in my locale.
The tests were failing due to use of the deprecated Date.parse()
method. Replaced Date.parse() calls in this test with equivalent
tests. Tests now pass.
a9b8fe1

Codecov Report

Merging #832 into master will increase coverage by 0.009%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master      #832       +/-   ##
===============================================
+ Coverage     64.864%   64.874%   +0.009%     
- Complexity      7195      7196        +1     
===============================================
  Files            527       527               
  Lines          31774     31774               
  Branches        5424      5424               
===============================================
+ Hits           20610     20613        +3     
+ Misses          9016      9014        -2     
+ Partials        2148      2147        -1
Impacted Files Coverage Δ Complexity Δ
...samtools/util/AsyncBlockCompressedInputStream.java 76% <0%> (+4%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbab32d...a9b8fe1. Read the comment docs.

Contributor

droazen commented Apr 4, 2017

👍

@droazen droazen merged commit 476adb2 into samtools:master Apr 4, 2017

4 checks passed

codecov/changes No unexpected coverage changes found.
Details
codecov/patch Coverage not affected when comparing bbab32d...a9b8fe1
Details
codecov/project 64.874% (+0.009%) compared to bbab32d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment