Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add fromPath to IntervalList. #846
Conversation
codecov-io
commented
Apr 7, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
==============================================
+ Coverage 64.86% 65.819% +0.959%
- Complexity 7195 7552 +357
==============================================
Files 527 527
Lines 31781 33334 +1553
Branches 5424 5889 +465
==============================================
+ Hits 20613 21940 +1327
- Misses 9020 9181 +161
- Partials 2148 2213 +65
|
| final IntervalList list = fromReader(reader); | ||
| try { | ||
| reader.close(); | ||
| } catch (final IOException e) { | ||
| - throw new SAMException(String.format("Failed to close file %s after reading",file)); |
lbergelson
Apr 7, 2017
Contributor
You might want to use the more ugly path.toUri().toString() because the path.toString() tends to drop the scheme.
nh13
was assigned
by yfarjoun
Apr 18, 2017
nh13
merged commit ee21d81
into
master
Apr 20, 2017
4 of 5 checks passed
codecov/changes
29 files have unexpected coverage changes not visible in diff.
Details
codecov/patch
85.714% of diff hit (target 64.86%)
Details
codecov/project
65.819% (+0.959%) compared to 476adb2
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
nh13
deleted the
nh_interval_list_path branch
Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nh13 commentedApr 7, 2017
I added a
fromPathmethod that is analogous to thefromFilestatic method inIntervalList. I added a simple test to make both behave similarly.