Maintain ordering of header #848

Merged
merged 1 commit into from Apr 8, 2017

Conversation

Projects
None yet
3 participants
Contributor

ronlevine commented Apr 7, 2017

Description

Implements #847.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)

ronlevine self-assigned this Apr 7, 2017

@ronlevine ronlevine requested review from bradtaylor and lbergelson Apr 7, 2017

Contributor

ronlevine commented Apr 7, 2017

@lbergelson Please review.

codecov-io commented Apr 7, 2017 edited

Codecov Report

Merging #848 into master will increase coverage by 0.006%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             master      #848       +/-   ##
==============================================
+ Coverage     64.86%   64.866%   +0.006%     
- Complexity     7195      7197        +2     
==============================================
  Files           527       527               
  Lines         31781     31781               
  Branches       5424      5424               
==============================================
+ Hits          20613     20615        +2     
  Misses         9020      9020               
+ Partials       2148      2146        -2
Impacted Files Coverage Δ Complexity Δ
src/main/java/htsjdk/variant/vcf/VCFUtils.java 24.706% <100%> (ø) 6 <6> (ø) ⬇️
...dk/samtools/seekablestream/SeekableHTTPStream.java 54.545% <0%> (-1.515%) 9% <0%> (-1%)
...main/java/htsjdk/samtools/SAMRecordSetBuilder.java 89.113% <0%> (+0.806%) 64% <0%> (+2%) ⬆️
...a/htsjdk/samtools/cram/encoding/rans/Decoding.java 85.714% <0%> (+3.571%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476adb2...31b761b. Read the comment docs.

ronlevine requested a review from yfarjoun Apr 7, 2017

Contributor

ronlevine commented Apr 7, 2017

@yfarjoun Could you take a look? Louis will be on vacation.

Contributor

yfarjoun commented Apr 7, 2017

looks good @ronlevine. Could you split into two commits, test and code change and push them separately (so that travis will initiate a build on both commits)? I'd like to see that the old code breaks the tests.

Contributor

ronlevine commented Apr 7, 2017

@yfarjoun Done. Take a look at the last 2 travis runs.

Contributor

yfarjoun commented Apr 8, 2017

Thank @ronlevine. 👍

@ronlevine ronlevine Maintain ordering of header
31b761b

@ronlevine ronlevine merged commit 3a75d02 into master Apr 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

ronlevine deleted the rhl_keep_header_ordering_847 branch Apr 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment