Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Maintain ordering of header #848
Conversation
ronlevine
self-assigned this
Apr 7, 2017
ronlevine
requested review from bradtaylor and lbergelson
Apr 7, 2017
|
@lbergelson Please review. |
codecov-io
commented
Apr 7, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
==============================================
+ Coverage 64.86% 64.866% +0.006%
- Complexity 7195 7197 +2
==============================================
Files 527 527
Lines 31781 31781
Branches 5424 5424
==============================================
+ Hits 20613 20615 +2
Misses 9020 9020
+ Partials 2148 2146 -2
Continue to review full report at Codecov.
|
ronlevine
requested a review
from yfarjoun
Apr 7, 2017
|
@yfarjoun Could you take a look? Louis will be on vacation. |
|
looks good @ronlevine. Could you split into two commits, test and code change and push them separately (so that travis will initiate a build on both commits)? I'd like to see that the old code breaks the tests. |
|
@yfarjoun Done. Take a look at the last 2 travis runs. |
|
Thank @ronlevine. |
ronlevine commentedApr 7, 2017
Description
Implements #847.
Checklist