Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix for SamLocusIterator.RecordAndOffset #849
Conversation
codecov-io
commented
Apr 10, 2017
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
===============================================
- Coverage 64.882% 64.856% -0.025%
+ Complexity 7198 7193 -5
===============================================
Files 527 527
Lines 31781 31778 -3
Branches 5424 5424
===============================================
- Hits 20620 20610 -10
- Misses 9016 9020 +4
- Partials 2145 2148 +3
Continue to review full report at Codecov.
|
|
simpler is better! |
yfarjoun
merged commit e1a37cf
into
samtools:master
Apr 16, 2017
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kamyshova commentedApr 10, 2017
Fix for issue: #828
In current version of master branch there is a problem with SamLocusIterator.RecordAndOffset class. This class inherits public method getRefPos that always returned -1.
We suggest to remove this method from AbstractRecordAndOffset class and replace it in abstract class EdgingRecordAndOffset, which heritors use this method.