Fix for SamLocusIterator.RecordAndOffset #849

Merged
merged 1 commit into from Apr 16, 2017

Conversation

Projects
None yet
4 participants
Contributor

kamyshova commented Apr 10, 2017

Fix for issue: #828

In current version of master branch there is a problem with SamLocusIterator.RecordAndOffset class. This class inherits public method getRefPos that always returned -1.

We suggest to remove this method from AbstractRecordAndOffset class and replace it in abstract class EdgingRecordAndOffset, which heritors use this method.

@ekazachkova ekazachkova replace method getRefPos() into abstract class EdgingRecordAndOffset …
…and delete constructor in AbstractRecordAndOffset
3728786

Codecov Report

Merging #849 into master will decrease coverage by 0.025%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master      #849       +/-   ##
===============================================
- Coverage     64.882%   64.856%   -0.025%     
+ Complexity      7198      7193        -5     
===============================================
  Files            527       527               
  Lines          31781     31778        -3     
  Branches        5424      5424               
===============================================
- Hits           20620     20610       -10     
- Misses          9016      9020        +4     
- Partials        2145      2148        +3
Impacted Files Coverage Δ Complexity Δ
...va/htsjdk/samtools/util/EdgingRecordAndOffset.java 67.568% <ø> (ø) 3 <0> (ø) ⬇️
.../htsjdk/samtools/util/AbstractRecordAndOffset.java 71.429% <ø> (-5.042%) 7 <0> (-2)
...sjdk/samtools/util/Md5CalculatingOutputStream.java 71.795% <0%> (-7.692%) 8% <0%> (-1%)
...samtools/util/AsyncBlockCompressedInputStream.java 72% <0%> (-4%) 12% <0%> (-1%)
...main/java/htsjdk/samtools/SAMRecordSetBuilder.java 88.306% <0%> (-0.806%) 62% <0%> (-2%)
...dk/samtools/seekablestream/SeekableHTTPStream.java 56.061% <0%> (+1.515%) 10% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a75d02...3728786. Read the comment docs.

Contributor

yfarjoun commented Apr 16, 2017

simpler is better!

👍

@yfarjoun yfarjoun merged commit e1a37cf into samtools:master Apr 16, 2017

2 of 4 checks passed

codecov/changes 3 files have unexpected coverage changes not visible in diff.
Details
codecov/project 64.856% (-0.025%) compared to 3a75d02
Details
codecov/patch Coverage not affected when comparing 3a75d02...3728786
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment