Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Adding a pre-test check that looks for java files in the test/scala d… #857
Conversation
| +} | ||
| + | ||
| + | ||
| +task FindScalaAndJavaTypes(type: Exec) { |
| + | ||
| + | ||
| +task FindScalaAndJavaTypes(type: Exec) { | ||
| + description = "Check for Scala outside the scala test dir and java files there." |
droazen
Apr 18, 2017
Contributor
"and java files there" -> "and java files in the scala test dir" (description is a little confusing as-is)
|
|
yfarjoun
was assigned
by droazen
Apr 18, 2017
codecov-io
commented
Apr 18, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
===============================================
+ Coverage 64.904% 64.926% +0.022%
- Complexity 7198 7210 +12
===============================================
Files 527 527
Lines 31784 31821 +37
Branches 5425 5433 +8
===============================================
+ Hits 20629 20660 +31
- Misses 9018 9021 +3
- Partials 2137 2140 +3
|
|
verbal |
yfarjoun
merged commit 4fa89b1
into
master
Apr 18, 2017
4 of 5 checks passed
codecov/changes
1 file has unexpected coverage changes not visible in diff.
Details
codecov/patch
Coverage not affected when comparing a44a5cd...b26e2c9
Details
codecov/project
64.926% (+0.022%) compared to a44a5cd
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
yfarjoun
deleted the
yf_add_check_of_java-scala_in_wrong_place branch
Apr 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
yfarjoun commentedApr 18, 2017
…irectory and for scala files anywhere else (and fails if it finds either of these)
Description
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Checklist