Adding a pre-test check that looks for java files in the test/scala d… #857

Merged
merged 3 commits into from Apr 18, 2017

Conversation

Projects
None yet
4 participants
Contributor

yfarjoun commented Apr 18, 2017

…irectory and for scala files anywhere else (and fails if it finds either of these)

Description

Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
@yfarjoun yfarjoun Adding a pre-test check that looks for java files in the test/scala d…
…irectory and for scala files anywhere else (and fails if it finds either of these)
3926caf
build.gradle
+}
+
+
+task FindScalaAndJavaTypes(type: Exec) {
@lbergelson

lbergelson Apr 18, 2017

Contributor

I think we usually start task names with lowercase

build.gradle
+
+
+task FindScalaAndJavaTypes(type: Exec) {
+ description = "Check for Scala outside the scala test dir and java files there."
@droazen

droazen Apr 18, 2017

Contributor

"and java files there" -> "and java files in the scala test dir" (description is a little confusing as-is)

Contributor

droazen commented Apr 18, 2017

👍 merge after addressing comments

yfarjoun was assigned by droazen Apr 18, 2017

codecov-io commented Apr 18, 2017 edited

Codecov Report

Merging #857 into master will increase coverage by 0.022%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master      #857       +/-   ##
===============================================
+ Coverage     64.904%   64.926%   +0.022%     
- Complexity      7198      7210       +12     
===============================================
  Files            527       527               
  Lines          31784     31821       +37     
  Branches        5425      5433        +8     
===============================================
+ Hits           20629     20660       +31     
- Misses          9018      9021        +3     
- Partials        2137      2140        +3
Impacted Files Coverage Δ Complexity Δ
...c/main/java/htsjdk/samtools/fastq/FastqReader.java 74.775% <0%> (-6.306%) 32% <0%> (+8%)
...main/java/htsjdk/samtools/SAMRecordSetBuilder.java 89.113% <0%> (+0.806%) 64% <0%> (+2%) ⬆️
...samtools/util/AsyncBlockCompressedInputStream.java 76% <0%> (+4%) 13% <0%> (+1%) ⬆️
...sjdk/samtools/util/Md5CalculatingOutputStream.java 79.487% <0%> (+7.692%) 9% <0%> (+1%) ⬆️

yfarjoun added some commits Apr 18, 2017

@yfarjoun yfarjoun responding to verbal review comments
83904da
@yfarjoun yfarjoun -extra space
b26e2c9
Contributor

yfarjoun commented Apr 18, 2017

verbal 👍 at review party.

@yfarjoun yfarjoun merged commit 4fa89b1 into master Apr 18, 2017

4 of 5 checks passed

codecov/changes 1 file has unexpected coverage changes not visible in diff.
Details
codecov/patch Coverage not affected when comparing a44a5cd...b26e2c9
Details
codecov/project 64.926% (+0.022%) compared to a44a5cd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

yfarjoun deleted the yf_add_check_of_java-scala_in_wrong_place branch Apr 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment