More informative IO error for FASTQ reader #865

Merged
merged 1 commit into from Apr 25, 2017

Conversation

Projects
None yet
3 participants
Contributor

magicDGS commented Apr 25, 2017

Description

Simple patch for a more informative IOException handling in FastqReader, by including the message and the line.

Checklist

  • Code compiles correctly
  • New tests covering changes and new functionality
  • All tests passing
  • Extended the README / documentation, if necessary
  • Is not backward compatible (breaks binary or source compatibility)
@magicDGS magicDGS More informative IO error for FASTQ reader
de65b0f
Contributor

magicDGS commented Apr 25, 2017

Can you please have a look to this simple patch, @tfenne? You were cleaning up a bit this class recently, and adding some more tests, so maybe it will be useful for you too.

Thanks in advance!

Codecov Report

Merging #865 into master will not change coverage.
The diff coverage is 0%.

@@             Coverage Diff             @@
##              master      #865   +/-   ##
===========================================
  Coverage     64.954%   64.954%           
  Complexity      7220      7220           
===========================================
  Files            528       528           
  Lines          31867     31867           
  Branches        5442      5442           
===========================================
  Hits           20699     20699           
  Misses          9020      9020           
  Partials        2148      2148
Impacted Files Coverage Δ Complexity Δ
...c/main/java/htsjdk/samtools/fastq/FastqReader.java 81.081% <0%> (ø) 24 <0> (ø) ⬇️
Owner

tfenne commented Apr 25, 2017

Looks good to me @magicDGS. I'll merge if nobody objects.

tfenne self-assigned this Apr 25, 2017

Contributor

magicDGS commented Apr 25, 2017

Thanks!

@tfenne tfenne merged commit 909ac4d into samtools:master Apr 25, 2017

3 of 4 checks passed

codecov/patch 0% of diff hit (target 64.954%)
Details
codecov/changes No unexpected coverage changes found.
Details
codecov/project 64.954% remains the same compared to 854d736
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment