updating artifactory link to point to new artifactory

[lbergelson]

• the Broad artifactory moved from a self hosted repository at artifactory.broadinstitute.org
  to a web based artifactory at broadinstitute.jfrog.io/broadinstitute/
  this was causing our snapshot uploads to fail
• updating our snapshot repository to point to the new link
• the old artifactory has a redirect in place to the new artifactory so
  artifacts relying on the old url should still resolve. For unknown
  reasons this redirect doesn't work with gradle uploads, probably a
  gradle bug.

[magicDGS]

One question about this for downstream projects using HTSJDK/GATK/etc: will the old artifactory links continue working forever or should we change them in the near future? Thanks in advance!

[lbergelson]

@magicDGS I was given a promise to keep the link up for at least a year, but I'm going to try to advocate for keeping the link around forever because it seems like really bad form to break old builds that way.

It's probably prudent to update even if the old link stays around though.

[codecov-io]

Codecov Report

Merging #892 into master will increase coverage by 0.136%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##              master     #892       +/-   ##
==============================================
+ Coverage     65.075%   65.21%   +0.136%     
- Complexity      7251     7346       +95     
==============================================
  Files            528      528               
  Lines          31931    32320      +389     
  Branches        5452     5577      +125     
==============================================
+ Hits           20779    21076      +297     
- Misses          9009     9089       +80     
- Partials        2143     2155       +12

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/htsjdk/samtools/SAMRecordUtil.java	23.529% <0%> (-20.915%)	2% <0%> (ø)
src/main/java/htsjdk/samtools/SAMRecord.java	66.176% <0%> (+0.245%)	286% <0%> (+1%)	⬆️
...dk/variant/variantcontext/GenotypeLikelihoods.java	85.294% <0%> (+0.632%)	85% <0%> (+16%)	⬆️
...a/htsjdk/samtools/cram/encoding/rans/Decoding.java	85.714% <0%> (+3.571%)	12% <0%> (+1%)	⬆️
src/main/java/htsjdk/samtools/SAMUtils.java	62.957% <0%> (+3.574%)	173% <0%> (+51%)	⬆️
src/main/java/htsjdk/variant/vcf/VCFEncoder.java	92.05% <0%> (+3.69%)	96% <0%> (+26%)	⬆️
src/main/java/htsjdk/tribble/util/HTTPHelper.java	55.738% <0%> (+4.627%)	4% <0%> (ø)	⬇️

[lbergelson]

@droazen Simple change here.

[droazen]

👍 merge when ready