Bug fix to the pileup constructor. #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We call constructor and destructor for each new bam object that is added to and removed from the pileup. Pileup also takes its own copy of the bam1_t struct as sam_read1 loops may be using the same structure over and over again. However the constructor was called with the passed in bam1_t instead of pileups own copy of it (unlike destructor). Hence anything the constructor attempts to cache, such as the location of an aux tag, may get written over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call constructor and destructor for each new bam object that is added to and removed from the pileup. Pileup also takes its own copy of the bam1_t struct as sam_read1 loops may be using the same structure over and over again.
However the constructor was called with the passed in bam1_t instead of pileups own copy of it (unlike destructor). Hence anything the constructor attempts to cache, such as the location of an aux tag, may get written over.