Check for gzopen() failure and print error messages #1013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all instances of
gzopen()
have appropriate error checking. In a couple of cases, lift thegzopen
to above some allocations so that the error path doesn't need to undo the allocations. Down in misc/*.c the infrastructure is lacking and we don't go to great lengths to e.g. return a non-zero status.Fixes another few instances of #51.
Noticed in bedcov by @rotifergirl (see https://twitter.com/Julie_B92/status/1097867250642628608).