Fix incorrect macro definition on Windows #950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_POSIX_C_SOURCE should have been _XOPEN_SOURCE. The value given to _POSIX_C_SOURCE caused the strdup() and M_PI definitions to disappear. For some unknown reason, Appveyor builds still worked despite this problem.
|
Nice catch. I guess this explains samtools/htslib#707… |
|
Yes. To add to the confusion, there are at least two sets of include files you can get with MSYS2. If you got them from I only noticed because I happened to download the msys2 version. |
|
Closed by 5708485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_POSIX_C_SOURCE should have been _XOPEN_SOURCE.
The value given to _POSIX_C_SOURCE caused the strdup() and M_PI definitions to disappear.
Not sure quite how Appveyor failed to spot this, but I think it may be because it builds with htslib in a subdirectory of samtools. It failed for me when they were in side-by-side directories.