Samuel Stauffer samuel

samuel commented on pull request samuel/go-zookeeper#38
@samuel

Also added better behavior if the connection continuously fails in authenticate. It'll try any other servers in the list without delay but will pro…

samuel closed pull request samuel/go-zookeeper#51
@samuel
Wrap connection Xid back to zero rather than overflowing to negative int32
samuel commented on pull request samuel/go-zookeeper#51
@samuel

This is a great point. Fixed it in a different way here though: 9c31c59 Wanted to avoid the contention of using CAS.

@samuel
  • @samuel d0e0d8e
    Avoid a busy loop when a connection repeatedly fails during authenticate
  • @samuel 7885480
    Merge branch 'master' of github.com:samuel/go-zookeeper
  • 1 more commit »
samuel closed pull request samuel/go-zookeeper#56
@samuel
fixed race around global resource
samuel commented on pull request samuel/go-zookeeper#56
@samuel

Closing this as I believe it's not an issue in this package. Feel free to reopen if you feel otherwise.

@samuel
samuel merged pull request samuel/go-zookeeper#38
@samuel
Fix continuous loop of connect attempts
1 commit with 8 additions and 1 deletion
samuel commented on pull request samuel/go-zookeeper#38
@samuel

Sorry, I totally forgot about this. I wanted to add a test, but this patch is probably the safest approach for now. Better to lose the session then…

samuel starred sim-/tgy
@samuel
samuel merged pull request samuel/go-zookeeper#54
@samuel
add support for some of the FourLetter words
2 commits with 784 additions and 0 deletions
samuel commented on pull request samuel/go-zookeeper#54
@samuel

No worries. Sorry to be picky. Looks good.

samuel commented on pull request samuel/go-zookeeper#56
@samuel

If I have the same version of the file as you then line number util.log:38 is s[i], s[j] = s[j], s[i] which means the race is on the server list. I…

@samuel
  • @samuel a7d37a3
    Copy the server list instead of mutating in-place
samuel commented on pull request samuel/go-zookeeper#56
@samuel

Thanks for the patch but it shouldn't be necessary according to http://golang.org/pkg/math/rand/ : The default Source is safe for concurrent use by…

samuel commented on pull request samuel/go-zookeeper#54
@samuel

Really minor doc issues but otherwise looks great. Thanks!

samuel commented on pull request samuel/go-zookeeper#54
@samuel

ServerClients instead of Clients

samuel commented on pull request samuel/go-zookeeper#54
@samuel

Should start with ServerClient instead of Client Typo on Zookeper

@samuel
@samuel
samuel merged pull request samuel/go-zookeeper#55
@samuel
[Fix] Conn.Close stops all goroutines if we haven't connencted yet
1 commit with 20 additions and 8 deletions
samuel commented on pull request samuel/go-zookeeper#55
@samuel

Good catch and patch looks great. Thanks!

samuel commented on issue samuel/go-zookeeper#52
@samuel

Are you able to reproduce this with zkCli or other client? This sounds like the server is rejecting the request rather than something controlled by…

@samuel

It's standard practice that the caller of a function is responsible for guaranteeing valid input into the function. For instance in the standard pa…