Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Menus are too dark in dark theme #1145

Open
samuelclay opened this issue Nov 5, 2018 · 12 comments

Comments

@samuelclay
Copy link
Owner

commented Nov 5, 2018

screenshot_20181104-220144

From a user email: "Please fix Dark and Black Themes so the menus are readible (see attached photo)."

@dosiecki

This comment has been minimized.

Copy link
Collaborator

commented Mar 15, 2019

I'm reasonably certain this is simply due to the fact that our themes are built on the light/dark platform default themes, and some ROMs have popped up that have defaults different than the stock ones. We should be able to simply copy some of the default/stock rules into our overrides.

@tjkirch

This comment has been minimized.

Copy link

commented Mar 15, 2019

I have this on stock (Android One) with nothing going on theme-wise at the system level, so I'm not sure it's due to the ROM?

@caleb-allen

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

@tjkirch are you still seeing this issue?

What device are you using?

@tjkirch

This comment has been minimized.

Copy link

commented May 28, 2019

@caleb-allen

@tjkirch are you still seeing this issue?

Yep, still have nearly unreadable menus. There hasn't been a NewsBlur Android update since July 19, 2018, so I'm not sure what would cause a change.

What device are you using?

I'm using a Moto X4 with Android 9. No root, nothing special. Newsblur is in "Dark" theme. (It's the same in the "Black" theme.)

@caleb-allen

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

I think @dosiecki is correct, that Motorola may have some subtle issues with their default holo theming.

If the main app theme is still respected on those manufacture ROMs, this should fix the issue, overriding the faulty default text color.

@tjkirch

This comment has been minimized.

Copy link

commented May 29, 2019

Does that mean that the next NewsBlur Android release will have more explicit styling to work around manufacturers' system-level styles? (Just hoping to understand)

@tjkirch

This comment has been minimized.

Copy link

commented May 29, 2019

Ah, now I see the related pull request, sorry - the client I'm using didn't show the connection.

@manderson23

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

I'm still seeing this on a Moto G6 running Android 9 (PPS29.55-24) with v9.0.1.

@samuelclay samuelclay reopened this Jul 28, 2019

@caleb-allen

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

@tjkirch did this fix your issue?

If not I'll need to get my hands on a Moto device, the app theme is being overridden somehow.

@tjkirch

This comment has been minimized.

Copy link

commented Aug 2, 2019

@caleb-allen Unfortunately not - I just confirmed the dark menu on v9.0.1.

@caleb-allen

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

I just confirmed the dark menu on v9.0.1.

Thanks for confirming. It seems that it's unique to Moto. I'm gonna need to get my hands on a device to test, or else a virtual Moto device.

@manderson23

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

I'll try to investigate further on my Moto device and see if I can fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.