New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix fetching tumblr rss feeds. #1140

Merged
merged 1 commit into from Nov 4, 2018

Conversation

Projects
None yet
2 participants
@jbouvier
Contributor

jbouvier commented Oct 26, 2018

After some digging I was able to find a workaround for broken tumblr rss feeds. I've verified that using this user agent does in fact work, at least for the time being.

@@ -1086,6 +1087,12 @@ def calculate_scores(cls, facet):
@property
def user_agent(self):
feed_parts = urlparse.urlparse(self.feed_address)

This comment has been minimized.

@jbouvier

jbouvier Oct 26, 2018

Contributor

It would probably be fine to skip urlparse and just do a .find directly on self.feed_address, but I was trying to be as specific as possible.

@samuelclay samuelclay merged commit 1d99f08 into samuelclay:master Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment