Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclass abcmeta #123

Merged
merged 3 commits into from Feb 6, 2018
Merged

Subclass abcmeta #123

merged 3 commits into from Feb 6, 2018

Conversation

@jcugat
Copy link
Contributor

@jcugat jcugat commented Feb 2, 2018

Implemented what we discussed in #120

Also changed pytest execution in the Makefile (was failing in my machine).

@codecov
Copy link

@codecov codecov bot commented Feb 2, 2018

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #123   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         852    853    +1     
  Branches      191    191           
=====================================
+ Hits          852    853    +1

Copy link
Owner

@samuelcolvin samuelcolvin left a comment

Looking good, we'll need some docs too.

Makefile Outdated
@@ -19,7 +19,7 @@ lint:

.PHONY: test
test:
pytest --cov=pydantic
Copy link
Owner

@samuelcolvin samuelcolvin Feb 2, 2018

remove these changes, the problem should be fixed by Teemu/pytest-sugar#133 which will hopefully be merged soon.

If the problems persist I'll remove pytest-sugar completely.

@jcugat
Copy link
Contributor Author

@jcugat jcugat commented Feb 2, 2018

What kind of documentation are you thinking about? Since it's in the stdlib the documentation is already there: https://docs.python.org/3/library/abc.html

Maybe just a mention in the changelog?

@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Feb 2, 2018

Just a show section in the main docs saying something like "pydantic works with python's standard abc" then a mini example in python.

@jcugat
Copy link
Contributor Author

@jcugat jcugat commented Feb 2, 2018

Tests are failing since I readded pytest-sugar to the Makefile.

@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Feb 2, 2018

Looks great. Thank you very much. I'll wait a couple of days in the hope that pytest-sugar gets fixed, if it doesn't I'll remove it.

Once that's done this looks ready to merge.

@samuelcolvin samuelcolvin merged commit 0600814 into samuelcolvin:master Feb 6, 2018
1 of 2 checks passed
@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Feb 6, 2018

great, thank you very much.

@jcugat jcugat deleted the subclass_abcmeta branch Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants