Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclass abcmeta #123

Merged
merged 3 commits into from Feb 6, 2018

Conversation

Projects
None yet
2 participants
@jcugat
Copy link
Contributor

jcugat commented Feb 2, 2018

Implemented what we discussed in #120

Also changed pytest execution in the Makefile (was failing in my machine).

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 2, 2018

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #123   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         852    853    +1     
  Branches      191    191           
=====================================
+ Hits          852    853    +1
@samuelcolvin
Copy link
Owner

samuelcolvin left a comment

Looking good, we'll need some docs too.

Makefile Outdated
@@ -19,7 +19,7 @@ lint:

.PHONY: test
test:
pytest --cov=pydantic

This comment has been minimized.

@samuelcolvin

samuelcolvin Feb 2, 2018

Owner

remove these changes, the problem should be fixed by Frozenball/pytest-sugar#133 which will hopefully be merged soon.

If the problems persist I'll remove pytest-sugar completely.

@jcugat

This comment has been minimized.

Copy link
Contributor Author

jcugat commented Feb 2, 2018

What kind of documentation are you thinking about? Since it's in the stdlib the documentation is already there: https://docs.python.org/3/library/abc.html

Maybe just a mention in the changelog?

@samuelcolvin

This comment has been minimized.

Copy link
Owner

samuelcolvin commented Feb 2, 2018

Just a show section in the main docs saying something like "pydantic works with python's standard abc" then a mini example in python.

Josep Cugat added some commits Feb 2, 2018

@jcugat jcugat force-pushed the jcugat:subclass_abcmeta branch from 5ba95b2 to f7a35b2 Feb 2, 2018

Josep Cugat
@jcugat

This comment has been minimized.

Copy link
Contributor Author

jcugat commented Feb 2, 2018

Tests are failing since I readded pytest-sugar to the Makefile.

@samuelcolvin

This comment has been minimized.

Copy link
Owner

samuelcolvin commented Feb 2, 2018

Looks great. Thank you very much. I'll wait a couple of days in the hope that pytest-sugar gets fixed, if it doesn't I'll remove it.

Once that's done this looks ready to merge.

@samuelcolvin samuelcolvin merged commit 0600814 into samuelcolvin:master Feb 6, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
deploy/netlify Deploy preview ready!
Details
@samuelcolvin

This comment has been minimized.

Copy link
Owner

samuelcolvin commented Feb 6, 2018

great, thank you very much.

@jcugat jcugat deleted the jcugat:subclass_abcmeta branch Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.