Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove use of ordered dict #126

Merged
merged 2 commits into from Feb 6, 2018

Conversation

Projects
None yet
1 participant
@samuelcolvin
Copy link
Owner

samuelcolvin commented Feb 6, 2018

as per https://mail.python.org/pipermail/python-dev/2017-December/151283.html dicts are ordered in python 3.6+. Therefore OrderedDict can be removed and marginally improve performance.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 6, 2018

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #126   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         873    871    -2     
  Branches      196    196           
=====================================
- Hits          873    871    -2

@samuelcolvin samuelcolvin merged commit 2b8216a into master Feb 6, 2018

5 checks passed

codecov/project 100% (+0%) compared to e3444ba
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@samuelcolvin samuelcolvin deleted the remove-ordered-dict branch Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.