Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include format with secret types #1424

Merged
merged 2 commits into from Apr 30, 2020
Merged

include format with secret types #1424

merged 2 commits into from Apr 30, 2020

Conversation

Atheuz
Copy link
Contributor

@Atheuz Atheuz commented Apr 23, 2020

Change Summary

include 'format': 'password' in the schema for secret types.

Related issue number

#546

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/1424-atheuz.md file added describing change

@codecov
Copy link

@codecov codecov bot commented Apr 23, 2020

Codecov Report

Merging #1424 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1424   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3747      3747           
  Branches       742       742           
=========================================
  Hits          3747      3747           
Impacted Files Coverage Δ
pydantic/types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f96c4dc...af9ac26. Read the comment docs.

@Atheuz
Copy link
Contributor Author

@Atheuz Atheuz commented Apr 23, 2020

Relates to #546

changes/1424-atheuz.md Outdated Show resolved Hide resolved
pydantic/types.py Outdated Show resolved Hide resolved
@Atheuz Atheuz requested a review from samuelcolvin Apr 24, 2020
@samuelcolvin samuelcolvin merged commit 9238e3d into samuelcolvin:master Apr 30, 2020
16 checks passed
@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Apr 30, 2020

thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants