Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added `le` and `ge` bounds to constrained numerics. #194
@@ Coverage Diff @@ ## master #194 +/- ## ===================================== Coverage 100% 100% ===================================== Files 10 10 Lines 1149 1172 +23 Branches 214 218 +4 ===================================== + Hits 1149 1172 +23
On Thu, 7 Jun 2018 at 16:30, Samuel Colvin ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In docs/examples/exotic.py <#194 (comment)>: > @@ -16,10 +16,12 @@ class Model(BaseModel): strip_str: constr(strip_whitespace=True) big_int: conint(gt=1000, lt=1024) = None + # inclusive: conint(ge=1000, le=1024) remove — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#194 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIKZDXr02EHf109uMBlgD5bO08C2xx-ks5t6TkCgaJpZM4UeXV_> .
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.