Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove msgpack #201

Merged
merged 2 commits into from Jun 18, 2018

Conversation

Projects
None yet
1 participant
@samuelcolvin
Copy link
Owner

samuelcolvin commented Jun 13, 2018

adding specific msgpack parsing was a mistake by me.

I'm a big fan of msgpack, and of course it's still "supported", you just need to parse the data yourself, then pass the result to pydantic.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 13, 2018

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #201   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines        1173   1173           
  Branches      221    221           
=====================================
  Hits         1173   1173

samuelcolvin added some commits Jun 13, 2018

@samuelcolvin samuelcolvin force-pushed the remove-msgpack branch from a58c18b to 00c9773 Jun 13, 2018

@samuelcolvin samuelcolvin merged commit 9338c41 into master Jun 18, 2018

5 checks passed

codecov/project 100% remains the same compared to 4f19d2b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@samuelcolvin samuelcolvin deleted the remove-msgpack branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.