Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.7 #216

Merged
merged 4 commits into from Jun 30, 2018
Merged

Add support for Python 3.7 #216

merged 4 commits into from Jun 30, 2018

Conversation

@layday
Copy link
Contributor

@layday layday commented Jun 30, 2018

No description provided.

@codecov
Copy link

@codecov codecov bot commented Jun 30, 2018

Codecov Report

Merging #216 into master will decrease coverage by 0.15%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage     100%   99.84%   -0.16%     
==========================================
  Files          11       11              
  Lines        1281     1285       +4     
  Branches      235      235              
==========================================
+ Hits         1281     1283       +2     
- Misses          0        2       +2

@layday
Copy link
Contributor Author

@layday layday commented Jun 30, 2018

Build only failing cuz of the Trafaret benchmark.

@layday
Copy link
Contributor Author

@layday layday commented Jun 30, 2018

By the way this only tests against 3.7.0a4 (same as nightly) since the Travis folks haven't been able to build later releases.

@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Jun 30, 2018

thanks a lot, could you add a line to HISTORY.rst. (I think you might have to start a new section).

We should disable the trafaret tests on 3.7, but I'll do that separately.

@layday
Copy link
Contributor Author

@layday layday commented Jun 30, 2018

Done that now. Want me to squash the commits?

@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Jun 30, 2018

No need, I'll squash when I merge.

However could you mark 3.7-dev as allowed to fail until we resolve the problem with benchmarks.

@layday
Copy link
Contributor Author

@layday layday commented Jun 30, 2018

It might make more sense to remove 3.7-dev seeing as it points to the same version as nightly.

@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Jun 30, 2018

Ok

@layday
Copy link
Contributor Author

@layday layday commented Jun 30, 2018

Done!

@samuelcolvin samuelcolvin merged commit 8f42e51 into samuelcolvin:master Jun 30, 2018
3 checks passed
@samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Jun 30, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants