New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning up _populate_sub_fields, support tuples #227

Merged
merged 5 commits into from Jul 10, 2018

Conversation

2 participants
@samuelcolvin
Owner

samuelcolvin commented Jul 10, 2018

kind of in preparation for #213 or just changes I found while researching for #213.

fixes #12.

@codecov

This comment has been minimized.

codecov bot commented Jul 10, 2018

Codecov Report

Merging #227 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #227   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines        1365   1427   +62     
  Branches      249    279   +30     
=====================================
+ Hits         1365   1427   +62

@samuelcolvin samuelcolvin changed the title from cleaning up _populate_sub_fields to cleaning up _populate_sub_fields, support tuples Jul 10, 2018

samuelcolvin added some commits Jul 10, 2018

@samuelcolvin

This comment has been minimized.

Owner

samuelcolvin commented Jul 10, 2018

@Gr1N feedback welcome.

@Gr1N

This comment has been minimized.

Collaborator

Gr1N commented Jul 10, 2018

LGTM

@samuelcolvin samuelcolvin merged commit 1dc2940 into master Jul 10, 2018

5 checks passed

codecov/project 100% (+0%) compared to c31b8d6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

@samuelcolvin samuelcolvin deleted the type-cleanup branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment