Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
JSON Schema update/refactor/augment, to conform to spec #308
Update/augment JSON Schema implementation to conform to JSON Schema spec
Related issue number
pydantic cares about performance, if there's any risk performance changed on this PR,
JSON Schemas are generaly only run once, and are also cached. As they are more like a "colateral" feature that is not involved in the normal worflow of Pydantic, I don't think performance could be affected or relevant for this PR.
@@ Coverage Diff @@ ## master #308 +/- ## ====================================== Coverage 100% 100% ====================================== Files 12 13 +1 Lines 1532 1703 +171 Branches 285 321 +36 ====================================== + Hits 1532 1703 +171
Looking good initially, but quite a lot to change.
I'll probably have some more stuff I want fixing once this is resolved but hard to see without fixing my initial concerns.
If there's loads more to do I might submit a PR against this PR to save you some time.
@tiangolo so far I have 51 emails from you (via github) in the last few days.
Please get the PR to the point where you'd like me to review it and let me know.
I don't need replies to every single code comment and every line changed doesn't need its own commit.
Thanks for the tips.
Sorry for that. Now I tried to avoid pushing before finishing with the rest of the review.
I see now that there are new conflicts with
Edit: I see you requested a rebase in another PR so I did that.
OK, that's it for now.
Python 3.7-dev keeps failing with some random race condition or something that comes from time to time. I could try re-pushing empty commits to try and make it run again, but I guess I that would trigger more emails. And we non-owners don't see the "Re-start build" button in Travis CI.
I think I already implemented all your requested changes.
If something else is missing or should be changed, let me know. I'll (hopefully) check it in the next days. But it's almost midnight here and I can't "extend" the weekend more. ...and my wife is not loving the project right now
frustratingly although it should let me, github isn't letting me push to your branch and therefore make changes to the PR.
Instead, I've submitted a PR tiangolo#1 to your repo on this branch. If you could review that, ask any questions and merge it.
If that's all ok, I think we'll be ok to merge this.
Awesome! I'll check it right away.